feat(macOS): disclaim tcc permissions for pty host process#321762
Draft
deepak1556 wants to merge 1 commit into
Draft
feat(macOS): disclaim tcc permissions for pty host process#321762deepak1556 wants to merge 1 commit into
deepak1556 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a macOS-focused disclaim option for VS Code’s Electron UtilityProcess wrapper and enables it for the terminal pty host utility process, aiming to change how macOS attributes TCC permission prompts for that process.
Changes:
- Added an optional
disclaimflag toIUtilityProcessConfiguration. - Threaded
disclaimthrough toelectron.utilityProcess.fork(...). - Enabled
disclaim: truewhen starting the pty host utility process.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/platform/utilityProcess/electron-main/utilityProcess.ts | Adds disclaim to the utility process configuration and forwards it into the Electron utilityProcess.fork options. |
| src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts | Sets disclaim: true for the pty host’s utility process startup configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307364