Skip to content

Bump uuid from 9.0.1 to 14.0.0 in /sync-api-service #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bump uuid from 9.0.1 to 14.0.0 in /sync-api-service #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f9a865
Bump uuid from 9.0.1 to 14.0.0 in /sync-api-service
dependabot[bot] Apr 22, 2026
22272e5
Fix build: replace uuid with Node.js crypto.randomUUID()
Copilot Apr 23, 2026
cbd5c6b
Update pipelines and @types/node to Node 22
Copilot Apr 23, 2026
a664a94
Restore uuid v14 using require() for Node 22.12+ ESM/CJS interop
Copilot Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/azure-pipelines/darwin/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
steps:
- task: NodeTool@0
inputs:
versionSpec: '20.15.1'
versionSpec: '22.x'
displayName: 'Install Node.js'

- script: |
Expand Down
2 changes: 1 addition & 1 deletion build/azure-pipelines/linux/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ steps:

- task: NodeTool@0
inputs:
versionSpec: '20.15.1'
versionSpec: '22.x'
displayName: 'Install Node.js'

- script: |
Expand Down
36 changes: 18 additions & 18 deletions build/azure-pipelines/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 20.15.1
- 22.x
- name: MacOS
nodeVersions:
- 20.15.1
- 22.x
- name: Windows
nodeVersions:
- 20.15.1
- 22.x
testSteps:
- template: /build/azure-pipelines/templates/test-steps.yml@self
parameters:
Expand All @@ -81,13 +81,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 20.15.1
- 22.x
- name: MacOS
nodeVersions:
- 20.15.1
- 22.x
- name: Windows
nodeVersions:
- 20.15.1
- 22.x
testSteps:
- template: /build/azure-pipelines/templates/test-steps.yml@self
parameters:
Expand All @@ -107,13 +107,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 20.15.1
- 22.x
- name: MacOS
nodeVersions:
- 20.15.1
- 22.x
- name: Windows
nodeVersions:
- 20.15.1
- 22.x
testSteps:
- template: /build/azure-pipelines/templates/test-steps.yml@self
parameters:
Expand All @@ -133,13 +133,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 20.15.1
- 22.x
- name: MacOS
nodeVersions:
- 20.15.1
- 22.x
- name: Windows
nodeVersions:
- 20.15.1
- 22.x
testSteps:
- template: /build/azure-pipelines/templates/test-steps.yml@self
parameters:
Expand All @@ -159,13 +159,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 20.15.1
- 22.x
- name: MacOS
nodeVersions:
- 20.15.1
- 22.x
- name: Windows
nodeVersions:
- 20.15.1
- 22.x
testSteps:
- template: /build/azure-pipelines/templates/test-steps.yml@self
parameters:
Expand All @@ -185,13 +185,13 @@ extends:
testPlatforms:
- name: Linux
nodeVersions:
- 20.15.1
- 22.x
- name: MacOS
nodeVersions:
- 20.15.1
- 22.x
- name: Windows
nodeVersions:
- 20.15.1
- 22.x
testSteps:
- template: /build/azure-pipelines/templates/test-steps.yml@self
parameters:
Expand Down
2 changes: 1 addition & 1 deletion build/azure-pipelines/win32/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
steps:
- task: NodeTool@0
inputs:
versionSpec: '20.15.1'
versionSpec: '22.x'
displayName: 'Install Node.js'

- script: |
Expand Down
38 changes: 29 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"devDependencies": {
"@types/assert": "^1.5.11",
"assert": "^2.1.0",
"@types/node": "^18.14.6",
"@types/node": "^22.0.0",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"esbuild": "^0.25.0",
Expand Down
59 changes: 40 additions & 19 deletions sync-api-service/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions sync-api-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
"fsChunks"
],
"dependencies": {
"uuid": "^9.0.1",
"vscode-uri": "^3.0.8",
"@vscode/sync-api-common": "0.9.0"
"@vscode/sync-api-common": "0.9.0",
"uuid": "^14.0.0",
"vscode-uri": "^3.0.8"
},
"devDependencies": {
"@types/vscode": "1.71.0",
"@types/uuid": "^9.0.7"
"@types/node": "^22.0.0",
"@types/vscode": "1.71.0"
},
"scripts": {
"prepublishOnly": "echo \"⛔ Can only publish from a secure pipeline ⛔\" && node ../build/npm/fail",
Expand Down
8 changes: 5 additions & 3 deletions sync-api-service/src/terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@

import { Event, EventEmitter, Pseudoterminal, Uri } from 'vscode';

import * as uuid from 'uuid';

import { RAL } from '@vscode/sync-api-common';
import { CharacterDeviceDriver, FileDescriptorDescription } from './device';

// uuid v14 is pure ESM; use require() which Node 22.12+ supports for synchronous ESM
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { v4: uuidV4 } = require('uuid') as { v4: () => string };

class LineBuffer {

private cursor: number;
Expand Down Expand Up @@ -232,7 +234,7 @@ class ServiceTerminalImpl implements ServicePseudoTerminal, CharacterDeviceDrive
this._onAnyKey = new EventEmitter<void>;
this.onAnyKey = this._onAnyKey.event;

const id = this.id = uuid.v4();
const id = this.id = uuidV4();
this.encoder = RAL().TextEncoder.create();
this.decoder = RAL().TextDecoder.create();

Expand Down
1 change: 1 addition & 0 deletions sync-api-service/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"composite": true,
"types": [
"node",
"vscode"
],
"module": "Node16",
Expand Down
Loading