Skip to content

fix: update sublime folder finder to support SublimeText from 4.x#149

Open
boxsnake wants to merge 3 commits into
microsoft:mainfrom
boxsnake-fork:fix/sublime-finder
Open

fix: update sublime folder finder to support SublimeText from 4.x#149
boxsnake wants to merge 3 commits into
microsoft:mainfrom
boxsnake-fork:fix/sublime-finder

Conversation

@boxsnake

Copy link
Copy Markdown

What changed

Former:

The plugin detect Sublime Text 3/Packages/Preferences.sublime-settings for Sublime Text settings.

Updated:

I changed this plugins for detecting both Sublime Text 3/Packages/Preferences.sublime-settings and Sublime Text/Packages/Preferences.sublime-settings for any existing SublimeText setting file.

Why

As for Sublime Text 4, it is named to Sublime Text. As a result, the settings file is located in Sublime Text folder rather than Sublime Text 3.

@ghost

ghost commented Feb 27, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@benjaminloerincz

Copy link
Copy Markdown

LGTM

@benjaminloerincz benjaminloerincz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkalabis lkalabis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jakob-Rufcbs Jakob-Rufcbs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@chrisands

Copy link
Copy Markdown

@joaomoreno can we merge it?

@benjaminloerincz

Copy link
Copy Markdown

@lszomoru @TylerLeonhardt can we merge it?

@Jakob-Ruf Jakob-Ruf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants