Skip to content

no config debug: Fix error when multiple vscode windows are open #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Zentrik wants to merge 9 commits into
base: main
Choose a base branch
from
Open

no config debug: Fix error when multiple vscode windows are open #918

Zentrik wants to merge 9 commits into from
+14 −23

Conversation

@Zentrik
Copy link

@Zentrik Zentrik commented Jan 6, 2026 •
edited
Loading

Should fix #916, but getting this installed locally seemed sufficiently complicated that I gave up. I figured out the nox stuff, I tested with two windows and this worked.
Fix is:

  1. Only watch a specific endpoint file
  2. Make sure this endpoint file is unique (I imagine the workspace file path can be non unique across vscode windows)

Zentrik added 4 commits January 6, 2026 23:11
@Zentrik
no config debug: Fix error when multiple vscode windows are open
c790e07 
Should fix microsoft#916, but getting this installed locally seemed sufficiently complicated that I gave up.
Fix is:
1. Only watch a specific endpoint file
2. Make sure this endpoint file is unique (I imagine the workspace file path can be non unique across vscode windows)
@Zentrik
[AI] Update tests
7e942c6
@Zentrik
Fix typo
eec9bbe
@Zentrik
Remove driveby fix
b4a023b
@Zentrik Zentrik mentioned this pull request Jan 8, 2026
Open
rchiodo
rchiodo previously approved these changes Jan 8, 2026
View reviewed changes
@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Jan 8, 2026
@rchiodo rchiodo closed this Jan 8, 2026
@rchiodo rchiodo reopened this Jan 8, 2026
@rchiodo
Copy link
Contributor

rchiodo commented Jan 8, 2026

Whoops, didn't meant to close this. @Zentrik it looks like this is causing a bunch of test failures.

Zentrik added 2 commits January 8, 2026 23:46
@Zentrik
Cleanup test and try to fix it failing on windows
c997d69 
I guess this is what I get for trusting AI at midnight.
@Zentrik
Fix failing test on windows take 2
bedc7d2 
The error seems to be that `base` is `c:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.noConfigDebugAdapterEndpoints` but `noConfigEndpointDir` is `C:\Users\RUNNER~1\AppData\Local\Temp\.noConfigDebugAdapterEndpoints` (the C is capitalised). Getting the fsPath of the URI should normalise the path the same as `base`.
@Zentrik
Copy link
Author

Zentrik commented Jan 9, 2026

@Zentrik it looks like this is causing a bunch of test failures.

Sorry about that, thanks for reviewing. I think it should be fixed now, o/w will have to wait till tmrw and I'll boot into windows to debug further.

@Zentrik
Copy link
Author

Zentrik commented Jan 10, 2026

Including the workspace part of the hash seems unnecessary given the inclusion of the sessionId so I removed it, with the added benefit that we now don't have to throw an error if no workspace folder is found. Including the sessionId in the hash does mean that the VSCODE_DEBUGPY_ADAPTER_ENDPOINTS env var changes if you reload the window/extension, but I couldn't see a way around that other than accepting that VSCODE_DEBUGPY_ADAPTER_ENDPOINTS might not be unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No Config Debugging errors when multiple vscode windows are open

2 participants

@Zentrik @rchiodo