Skip to content

Conversation

@mrleemurray
Copy link
Contributor

This pull request makes minor style adjustments to the webviews/common/common.css file, focusing on improving the appearance of disabled buttons and split button groups.

Button styling updates:

  • Updated the border color for disabled buttons to use --vscode-button-background instead of --vscode-button-border for better visual consistency.
  • Added top and bottom borders to .split.disabled elements, using --vscode-button-background to enhance the visual separation of disabled split buttons.

@mrleemurray mrleemurray added this to the January 2026 milestone Jan 21, 2026
@mrleemurray mrleemurray self-assigned this Jan 21, 2026
Copilot AI review requested due to automatic review settings January 21, 2026 15:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates button border styles in the webviews CSS, specifically targeting disabled button states and split button groups. The changes aim to improve visual consistency by modifying border colors for disabled UI elements.

Changes:

  • Modified disabled button border styling to use --vscode-button-background instead of --vscode-button-border
  • Added explicit top and bottom borders to disabled split buttons using --vscode-button-background

input[type='submit']:disabled {
opacity: 0.4;
border: 1px solid var(--vscode-button-border, transparent) !important;
border: 1px solid var(--vscode-button-background, transparent) !important;
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --vscode-button-background for border styling is semantically incorrect. The variable --vscode-button-background is intended for background colors, not borders. This could cause visual inconsistencies in themes where these variables have different color values. Consider using --vscode-button-border if the goal is to maintain a border, or removing the border entirely for disabled buttons with border: 1px solid transparent !important;.

Suggested change
border: 1px solid var(--vscode-button-background, transparent) !important;
border: 1px solid var(--vscode-button-border, transparent) !important;

Copilot uses AI. Check for mistakes.
Comment on lines +399 to +400
border-top: 1px solid var(--vscode-button-background);
border-bottom: 1px solid var(--vscode-button-background);
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --vscode-button-background for border styling is semantically incorrect. The non-disabled .split class uses --vscode-button-border for its top and bottom borders (lines 386-387), so the disabled state should maintain the same semantic variable usage. Consider keeping --vscode-button-border or using a transparent border instead.

Suggested change
border-top: 1px solid var(--vscode-button-background);
border-bottom: 1px solid var(--vscode-button-background);
border-top: 1px solid var(--vscode-button-border);
border-bottom: 1px solid var(--vscode-button-border);

Copilot uses AI. Check for mistakes.
@mrleemurray mrleemurray merged commit c367b6f into main Jan 21, 2026
12 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/pretty-anaconda-rose branch January 21, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants