Add settings to control the icons used in Issues and PR tree views #6798
+99
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Example render screenshots:PR mode
Issues mode
PR mode
Issues mode
|
Member
|
Thanks for the PR @kabel. What is the benefit of having the |
Contributor
Author
I don't have a compelling reason. A few thoughts being:
|
)
kabel
force-pushed
the
feature/6641-tree-view-icon-mode
branch
from
49d4f13 to
eb19824
Compare
kabel
force-pushed
the
feature/6641-tree-view-icon-mode
branch
from
eb19824 to
dfef005
Compare
Implements the feature request microsoft#6641. Both tree views support an icon mode of `author` (default), `state`, or `generic`. `author` follows the existing logic prior to this setting, where we attempt to fetch a rounded avatar. PRs fall back to a GitHub icon and Issues fall back to state-specific icon. `state` will always use a state-specific icon that matches the Issue/PR type and state. `generic` will always use the GitHub icon for a PR and an uncolored issues theme icon for Issues.
kabel
force-pushed
the
feature/6641-tree-view-icon-mode
branch
from
dfef005 to
84c29ed
Compare
Member
|
Thanks for your patience on this. I'm planning to review it on Friday when we open our main branch back up for August changes. |
Member
|
@copilot I have sadly neglected this PR, which adds two settings for controlling which icon shows for view tree items: one setting for PRs and the other for issues. In the time since this PR was created, a setting was added which covers part of the feature for issues, but it's missing the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the feature request #6641.
Both tree views support an icon mode of
author(default),state, orgeneric.authorfollows the existing logic prior to this setting, where we attempt to fetch a rounded avatar. PRs fall back to a GitHub icon and Issues fall back to state-specific icon.statewill always use a state-specific icon that matches the Issue/PR type and state.genericwill always use the GitHub icon for a PR and an uncolored issues theme icon for Issues.