Skip to content

Fix: Check doResolveProxy#90

Merged
chrmarti merged 2 commits intomainfrom
chrmarti/allied-llama
Mar 11, 2026
Merged

Fix: Check doResolveProxy#90
chrmarti merged 2 commits intomainfrom
chrmarti/allied-llama

Conversation

@chrmarti
Copy link

@chrmarti chrmarti commented Mar 11, 2026

@chrmarti chrmarti force-pushed the chrmarti/allied-llama branch from f2e7a63 to 513ad37 Compare March 11, 2026 10:34
@chrmarti chrmarti changed the title WIP Fix: Check doResolveProxy Mar 11, 2026
@chrmarti chrmarti marked this pull request as ready for review March 11, 2026 10:37
@vs-code-engineering vs-code-engineering bot added this to the 1.112.0 milestone Mar 11, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes WebSocket proxy handling so the WebSocket patch respects the doResolveProxy and addCerts flags, and adjusts a flaky proxy-auth test to assert the 407 response status directly.

Changes:

  • Pass doResolveProxy / addCerts into the WebSocket ProxyDispatcher and use them when resolving proxy + loading extra certs.
  • Update the “missing auth” proxy test to use https.request and assert res.statusCode === 407 without relying on body end.
  • Bump version to 0.39.1 and document the fixes in the changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/test-client/src/proxy.test.ts Reworks the 407-missing-auth test to assert status code directly to avoid intermittent stream completion issues.
src/index.ts Fixes WebSocket ProxyDispatcher to honor doResolveProxy/addCerts from createWebSocketPatch.
package.json Version bump to 0.39.1.
CHANGELOG.md Adds 0.39.1 entry describing the WebSocket and test fixes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chrmarti chrmarti merged commit d5c3bd9 into main Mar 11, 2026
10 checks passed
@chrmarti chrmarti deleted the chrmarti/allied-llama branch March 11, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants