Conversation
f2e7a63 to
513ad37
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes WebSocket proxy handling so the WebSocket patch respects the doResolveProxy and addCerts flags, and adjusts a flaky proxy-auth test to assert the 407 response status directly.
Changes:
- Pass
doResolveProxy/addCertsinto the WebSocketProxyDispatcherand use them when resolving proxy + loading extra certs. - Update the “missing auth” proxy test to use
https.requestand assertres.statusCode === 407without relying on bodyend. - Bump version to
0.39.1and document the fixes in the changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test-client/src/proxy.test.ts | Reworks the 407-missing-auth test to assert status code directly to avoid intermittent stream completion issues. |
| src/index.ts | Fixes WebSocket ProxyDispatcher to honor doResolveProxy/addCerts from createWebSocketPatch. |
| package.json | Version bump to 0.39.1. |
| CHANGELOG.md | Adds 0.39.1 entry describing the WebSocket and test fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexr00
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/vscode#298236