Improve crash call stack data.#14555
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how C/C++ crash telemetry is generated in the extension to make crash call stack data easier to read and analyze by removing the separate “offset/address” telemetry field and restructuring the emitted crash header/details.
Changes:
- Removes the separate
CrashingThreadCallStackOffsetstelemetry property and simplifies the telemetry logging helpers. - Changes the crash telemetry header/signal formatting (adds
si_code/si_addrinline) and alters how address/offset data is appended to the call stack text. - Updates the “C/C++ Crash Call Stacks” output formatting to include the new signal info.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Colengms
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous crash call stack data was unnecessarily hard to analyze.
Fixed by Copilot with Claude Opus 4.8 in VS Code.