Skip to content

Improve crash call stack data.#14555

Merged
sean-mcmanus merged 5 commits into
mainfrom
seanmcm/improveCallStackData
Jun 30, 2026
Merged

Improve crash call stack data.#14555
sean-mcmanus merged 5 commits into
mainfrom
seanmcm/improveCallStackData

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The previous crash call stack data was unnecessarily hard to analyze.

  • Change "cpptools-srv2.txt" to "cpptools-srv2 process" so it's self-explanatory what it describes.
  • Move address data that was consistent between crashes into the main crash call stack section and remove the inconsistent address data.

Fixed by Copilot with Claude Opus 4.8 in VS Code.

@sean-mcmanus sean-mcmanus requested a review from a team as a code owner June 29, 2026 17:03
@github-project-automation github-project-automation Bot moved this to Pull Request in cpptools Jun 29, 2026
@sean-mcmanus sean-mcmanus added this to the 1.33.3 milestone Jun 29, 2026
@sean-mcmanus sean-mcmanus requested a review from Copilot June 29, 2026 17:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how C/C++ crash telemetry is generated in the extension to make crash call stack data easier to read and analyze by removing the separate “offset/address” telemetry field and restructuring the emitted crash header/details.

Changes:

  • Removes the separate CrashingThreadCallStackOffsets telemetry property and simplifies the telemetry logging helpers.
  • Changes the crash telemetry header/signal formatting (adds si_code/si_addr inline) and alters how address/offset data is appended to the call stack text.
  • Updates the “C/C++ Crash Call Stacks” output formatting to include the new signal info.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread Extension/src/LanguageServer/extension.ts Outdated
@sean-mcmanus sean-mcmanus enabled auto-merge (squash) June 30, 2026 20:54
@sean-mcmanus sean-mcmanus merged commit fe18c4a into main Jun 30, 2026
6 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/improveCallStackData branch June 30, 2026 20:55
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants