Skip to content

Update eslint from 8 to 9.#14157

Merged
sean-mcmanus merged 19 commits into
mainfrom
seanmcm/updateEslint
Feb 5, 2026
Merged

Update eslint from 8 to 9.#14157
sean-mcmanus merged 19 commits into
mainfrom
seanmcm/updateEslint

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

This was mostly done by Copilot Agent mode...well, the initial edit...I had to fix a bunch of stuff it did.

@sean-mcmanus
sean-mcmanus requested a review from a team as a code owner February 2, 2026 22:02
@github-project-automation github-project-automation Bot moved this to Pull Request in cpptools Feb 2, 2026
@sean-mcmanus
sean-mcmanus requested a review from Copilot February 2, 2026 22:03

This comment was marked as resolved.

@sean-mcmanus
sean-mcmanus marked this pull request as draft February 2, 2026 22:10
@sean-mcmanus

This comment was marked as resolved.

@sean-mcmanus
sean-mcmanus requested a review from Copilot February 2, 2026 22:58
@sean-mcmanus
sean-mcmanus marked this pull request as ready for review February 2, 2026 22:59

This comment was marked as resolved.

@sean-mcmanus
sean-mcmanus requested a review from Copilot February 2, 2026 23:08

This comment was marked as resolved.

Comment thread Extension/.scripts/clean.ts
Comment thread Extension/.scripts/clean.ts Outdated
Comment thread Extension/.scripts/common.ts
Comment thread Extension/.scripts/common.ts
@sean-mcmanus
sean-mcmanus requested a review from Colengms February 3, 2026 00:20
@sean-mcmanus

This comment was marked as resolved.

Colengms
Colengms previously approved these changes Feb 3, 2026
@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

@bobbrow Were all your concerns addressed?

@bobbrow

bobbrow commented Feb 3, 2026

Copy link
Copy Markdown
Member

@bobbrow Were all your concerns addressed?

I haven't had the time to go through very many files yet.

Comment thread Extension/src/LanguageServer/client.ts Outdated
Comment thread Extension/eslint.config.js

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Extension/.scripts/common.ts
Comment thread Extension/src/LanguageServer/client.ts
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/eslint.config.js
Comment thread Extension/src/LanguageServer/cppBuildTaskProvider.ts Outdated
bobbrow
bobbrow previously approved these changes Feb 4, 2026

@bobbrow bobbrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one optional comment

Comment thread Extension/src/LanguageServer/clientCollection.ts Outdated
Comment thread Extension/src/LanguageServer/protocolFilter.ts Outdated
@sean-mcmanus
sean-mcmanus merged commit 05d57e1 into main Feb 5, 2026
6 checks passed
@sean-mcmanus
sean-mcmanus deleted the seanmcm/updateEslint branch February 5, 2026 22:20
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants