Refactor RunningFunctionTaskMap to use composite string key

[nturinski]

Summary

Replaces Map<WorkspaceFolder|TaskScope, IRunningFuncTask[]> with Map<string, IRunningFuncTask> using a composite key derived from folder.uri + normalized cwd. This eliminates the linear array search in .get() and moves the ${workspaceFolder} path resolution out of the map class into a shared resolveAndNormalizeCwd() utility.

Also removes TaskScope from all type signatures since FuncTaskProvider already filters out Global/Workspace scoped tasks, making TaskScope dead code across the codebase.

Changes

Core (funcHostTask.ts)

• RunningFunctionTaskMap — internal map is now Map<string, IRunningFuncTask> with a composite key (folder.uri.toString() + "::" + normalizedCwd). No more array storage or linear search.
• resolveAndNormalizeCwd() — new exported utility that handles ${workspaceFolder} replacement + normalizePath(). All callers use this before interacting with the map.
• .set(folder, normalizedCwd, task) — takes normalized cwd as an explicit parameter.
• .get()/.has() — direct O(1) map lookups instead of Array.find().
• .delete(folder, cwd?) / .getAll(folder) — prefix-match for killAll and tree-view cases.
• IStoppedFuncTask.workspaceFolder, IRunningFuncTaskWithScope.scope — narrowed from WorkspaceFolder | TaskScope to WorkspaceFolder.
• stopFuncTaskIfRunning(), killFuncProcessByPortOrPid(), getFuncPortFromTaskOrProject() — narrowed parameter types.
• Event handlers now include a defensive typeof scope === 'object' guard and normalize cwd before all map operations.

Dependent files (8 files)

• funcHostDebugUtils.ts — getScopeLabel() narrowed, removed dead 'Global' branch.
• HostTaskNode.ts — narrowed constructor, normalizes cwd before .get().
• HostErrorNode.ts — narrowed constructor param.
• registerFunctionHostDebugView.ts — normalizes cwd before all .get() calls.
• pickFuncProcess.ts — normalizes buildPath before .has() and .get().
• LocalProject.ts — now passes effectiveProjectPath (always available) for more correct map lookups instead of relying on no-arg fallback.
• listLocalFunctions.ts — normalizes effectiveProjectPath before .has().
• LocalProjectTreeItem.ts — removed TaskScope import, narrowed onFuncTaskChanged.

Testing

• npm run build:check passes with zero type errors.
• All unit tests pass.

[Copilot]

Pull request overview

Refactors function-host task tracking to use a composite string key (workspaceFolder URI + normalized cwd) so running task lookup is O(1) and ${workspaceFolder}/cwd normalization is centralized in a new utility.

Changes:

• Replaced Map<WorkspaceFolder|TaskScope, IRunningFuncTask[]> with Map<string, IRunningFuncTask> keyed by folderUri + "::" + normalizedCwd.
• Added resolveAndNormalizeCwd() and updated call sites to normalize cwd/build paths prior to map operations.
• Narrowed multiple APIs/events/interfaces to use WorkspaceFolder only (removing TaskScope).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/funcCoreTools/funcHostTask.ts	Implements the composite-key map, adds resolveAndNormalizeCwd, and narrows scope types.
src/workspace/LocalProject.ts	Uses normalized effective project path for running host port lookup.
src/workspace/listLocalFunctions.ts	Uses normalized effective project path when checking if host is running.
src/tree/localProject/LocalProjectTreeItem.ts	Narrows func-task event scope typing to WorkspaceFolder.
src/debug/registerFunctionHostDebugView.ts	Normalizes cwd before map lookups for debug view actions.
src/debug/nodes/HostTaskNode.ts	Normalizes cwd before reading task details/errors from the map.
src/debug/nodes/HostErrorNode.ts	Narrows stored scope to WorkspaceFolder.
src/debug/nodes/funcHostDebugUtils.ts	Removes dead Global scope label branch; WorkspaceFolder only.
src/commands/pickFuncProcess.ts	Normalizes build path for has/get checks against the new map.

[Copilot]

In stopFuncTaskIfRunning, when buildPath is omitted normalizedBuildPath is undefined, but the map entry is never deleted (if (normalizedBuildPath) ...). This leaves stale entries for hosts started with the default cwd (no explicit options.cwd), causing runningFuncTaskMap.has/get to think the host is still running. Consider deleting the folder-only key when normalizedBuildPath is undefined (or always delete the specific key you looked up).

Suggested change

	if (normalizedBuildPath) {
	if (!killAll) {

[Copilot]

RunningFunctionTaskMap.delete(folder, normalizedCwd?) treats normalizedCwd === undefined as “delete all entries for this folder”. That makes it impossible to delete a single entry whose normalized cwd is actually undefined (i.e., tasks that rely on the default cwd). In the current code, onDidEndTaskProcess calls runningFuncTaskMap.delete(scope, normalizedCwd) where normalizedCwd can be undefined, which would wipe all running tasks for that folder. Consider separating the APIs (e.g., deleteOne(folder, cwdKey) vs deleteAll(folder)), or using a sentinel value for the default-cwd key so single-entry deletion is always possible.

[nturinski]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied all three reviewer suggestions in commits e7bb0c1 and 83f607e:

1. resolveAndNormalizeCwd (resolved thread) — already used folder.uri.fsPath + global split/join in the previous commit.

2. delete API ambiguity — split the old delete(folder, cwd?) into two explicit methods:

   • deleteOne(folder, normalizedCwd: string | undefined) — deletes exactly the one entry at makeKey(folder, normalizedCwd), even when normalizedCwd is undefined.
   • deleteAll(folder) — prefix-match delete for the killAll case.

3. Stale entry in stopFuncTaskIfRunning — removed the if (normalizedBuildPath) guard so we always call deleteOne/deleteAll, ensuring tasks started with the default cwd (no explicit buildPath) don't leave stale map entries.

[nturinski]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in commit a562148f. The two conflicting files were funcHostTask.ts and pickFuncProcess.ts:

• funcHostTask.ts: kept our typeof scope === 'object' guard, rawCwd/normalizedCwd naming, and deleteOne API; picked up main's workerPidFile/workerProcessId fields and dotnet-isolated stream parsing logic.
• pickFuncProcess.ts: kept our resolveAndNormalizeCwd import alongside main's new jsonOutputFile utilities import.