Fix long running tests in support of migration to esbuild#1081
Draft
MicroFish91 wants to merge 21 commits into
Draft
Fix long running tests in support of migration to esbuild#1081MicroFish91 wants to merge 21 commits into
MicroFish91 wants to merge 21 commits into
Conversation
MicroFish91
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MicroFish91
commented
May 19, 2026
| ".vscode-test": true | ||
| } | ||
| }, | ||
| "js/ts.tsdk.path": "node_modules/typescript/lib", |
Contributor
Author
There was a problem hiding this comment.
Fixes the mocha warnings that have been showing up
| return { | ||
| name: localize('containerAppEnvironment', 'Container Apps Environment'), | ||
| value: nonNullValueAndProp(context.managedEnvironment, 'name'), | ||
| value: context.managedEnvironment?.name ?? context.newManagedEnvironmentName ?? '', |
Contributor
Author
There was a problem hiding this comment.
Note for future confirmations - we should prefer optionals over nonNull for these sections, I think it can still run when users select to create a new resource, in which case it could still be undefined when this gets run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are now updated to be compatible with the ES build work. I also fixed a few smaller issues that cropped up since the tests hadn’t been running for a while.
One annoying change: I used to just delete the .vscode/ folder in each project between deployments and that worked just fine... but that’s apparently no longer enough. I assume a newer VS Code update introduced some kind of caching behavior that now has to be explicitly reset through the API; otherwise deployments can still pick up older cached settings even if the folder was deleted.
Update: The remote subscription we use only seems to support 1 container environment so I'm requesting an increase in quotas before I do a final verification pass