fix(http-server-js): send bytes body directly without JSON serialization#10610
Open
snipd-mikel wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(http-server-js): send bytes body directly without JSON serialization#10610snipd-mikel wants to merge 1 commit intomicrosoft:mainfrom
snipd-mikel wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree [company="Snipd AG"] |
Author
|
@microsoft-github-policy-service agree company="Snipd AG" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an operation returns a
bytesbody with a custom@header contentType(e.g.
"application/zip"), the emitter was unconditionally overwriting thecontent-type with
"application/json"and calling the non-existentUint8Array.toJsonObject(), causing a runtime crash.Add a
isStdType(body.type, "bytes")check inemitResultProcessingForTypebefore the JSON serialization path — mirroring the equivalent check already
present on the request deserialization side (added in #6898) — so that binary
responses are written directly to the response stream with the content-type
already set by the
@headerproperty.Fixes #10609