createProgram - #4914
Conversation
There was a problem hiding this comment.
Pull request overview
Adds native createProgram support with isolated snapshots, incremental reuse, project references, diagnostics, and sync/async API exposure.
Changes:
- Adds server protocol and snapshot-backed program creation.
- Supports old-program reuse, file changes, references, and config diagnostics.
- Adds Go and TypeScript integration tests.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
internal/tsoptions/parsedcommandline.go |
Adds project references to parsed command lines. |
internal/tsoptions/commandlineparser.go |
Updates constructor usage. |
internal/project/snapshot.go |
Implements isolated program snapshots. |
internal/project/projectcollectionbuilder.go |
Updates synthetic inferred projects and reuse logic. |
internal/project/project.go |
Adds synthetic-project seeding and metadata propagation. |
internal/project/project_test.go |
Tests inferred-project option updates. |
internal/project/api.go |
Exposes program snapshot creation. |
internal/execute/tsc/emit_test.go |
Updates constructor usage. |
internal/compiler/projectreferenceparser.go |
Supports config-less reference roots. |
internal/compiler/projectreferencefilemapper.go |
Handles synthetic root config paths. |
internal/ast/diagnostic.go |
Adds text-based diagnostic construction. |
internal/api/session.go |
Handles createProgram requests. |
internal/api/session_createprogram_test.go |
Tests creation, reuse, references, and isolation. |
internal/api/proto.go |
Defines protocol types and diagnostic conversion. |
_packages/native-preview/test/sync/api.test.ts |
Adds synchronous API tests. |
_packages/native-preview/test/async/api.test.ts |
Adds asynchronous API tests. |
_packages/native-preview/src/api/sync/api.ts |
Exposes synchronous createProgram. |
_packages/native-preview/src/api/proto.ts |
Adds client protocol types. |
_packages/native-preview/src/api/async/api.ts |
Exposes asynchronous createProgram. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| func (d *DiagnosticResponse) ToDiagnostic() *ast.Diagnostic { | ||
| return ast.NewDiagnosticFromText( | ||
| nil, |
There was a problem hiding this comment.
I'll need something similar here to what we'll have to do to set up formatDiagnostics, i.e. retrieving a file from the file name associated to a JS-side diagnostic. I'll leave this like that until then.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…t/typescript-go into gabritto/create_program
| } | ||
|
|
||
| projectCollectionBuilder.DidChangeCustomConfigFileName(logger.Fork("DidChangeCustomConfigFileName")) | ||
| // compiler options changed, update inferred project and program |
There was a problem hiding this comment.
This is a drive-by fix, since I was already working on updateInferredProject.
|
Thank you for contributing to the TypeScript native port! Development has moved from this repository back to the main microsoft/TypeScript repository. GitHub does not have PR transfer functionality, so we're closing this PR here. If this change is still relevant, please reopen it as a new pull request in See microsoft/typescript-go#4918 for more information about the move. |
This PR adds
createProgramto the API.The API is similar to what we had in Strada, where we take root file names, compiler options, and optionally project references and config file parsing diagnostics, and return a program.
It also optionally takes an
oldProgramand file changes to apply to this old program to construct a new program.Because this API allows you to evolve a program over time by applying changes, its implementation is based on snapshots. So each program returned by this API has a corresponding snapshot to back it. But the process for creating such a snapshot is a little different from the usual: we want this snapshot to back only the one program we're creating. So there's a new
snapshot.cloneForProgramjust for that. The way it works is that we create a new synthetic inferred project during clone that will contain the root file names and compiler options that were provided viacreateProgram.The
oldProgramdoesn't necessarily have to be created bycreateProgrameither, but it does need to be backed by a server-side snapshot (this may need to change in the future: I'm not sure this would work for the programs created by the upcoming solution builder API).If an
oldProgramisn't provided, we rely on the updated server snapshot as a base for creating the program.