Skip to content

Default Azure DevOps groups to off - #10474

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/disable-parallel-azdo-groups
Aug 6, 2026
Merged

Default Azure DevOps groups to off#10474
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/disable-parallel-azdo-groups

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • default Azure DevOps per-assembly log groups to off
  • keep --report-azdo-groups on as an explicit opt-in for single or serialized assembly execution
  • update help text, localization sources, and default/explicit-value test coverage

Azure DevOps ##[group] and ##[endgroup] commands are sequential and anonymous, so parallel assembly output can interleave and create incorrect nesting.

Related documentation: dotnet/docs#55325

Validation

  • dotnet test --project test\UnitTests\Microsoft.Testing.Extensions.UnitTests\Microsoft.Testing.Extensions.UnitTests.csproj --framework net9.0 --filter "FullyQualifiedName~AzureDevOpsLogGroupReporterTests" (9 passed)
  • dotnet test --project test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj --framework net11.0 --filter "FullyQualifiedName~HelpInfoAllExtensionsTests" (9 passed)
  • git diff --check

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Defaults Azure DevOps per-assembly log groups to off, preventing malformed nesting during parallel execution while retaining explicit opt-in.

Changes:

  • Requires --report-azdo-groups on to enable grouping.
  • Updates help text and localization sources.
  • Verifies the new default with unit and acceptance tests.
Show a summary per file
File Description
AzureDevOpsLogGroupReporter.cs Implements explicit opt-in behavior.
AzureDevOpsResources.resx Updates the default description.
AzureDevOpsResources.cs.xlf Refreshes Czech localization metadata.
AzureDevOpsResources.de.xlf Refreshes German localization metadata.
AzureDevOpsResources.es.xlf Refreshes Spanish localization metadata.
AzureDevOpsResources.fr.xlf Refreshes French localization metadata.
AzureDevOpsResources.it.xlf Refreshes Italian localization metadata.
AzureDevOpsResources.ja.xlf Refreshes Japanese localization metadata.
AzureDevOpsResources.ko.xlf Refreshes Korean localization metadata.
AzureDevOpsResources.pl.xlf Refreshes Polish localization metadata.
AzureDevOpsResources.pt-BR.xlf Refreshes Brazilian Portuguese localization metadata.
AzureDevOpsResources.ru.xlf Refreshes Russian localization metadata.
AzureDevOpsResources.tr.xlf Refreshes Turkish localization metadata.
AzureDevOpsResources.zh-Hans.xlf Refreshes Simplified Chinese localization metadata.
AzureDevOpsResources.zh-Hant.xlf Refreshes Traditional Chinese localization metadata.
AzureDevOpsLogGroupReporterTests.cs Tests the disabled-by-default behavior.
HelpInfoAllExtensionsTests.cs Updates help and info expectations.

Review details

  • Files reviewed: 17/17 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@Evangelink Amaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 6, 2026
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) August 6, 2026 10:28
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7ffe4547-0bee-408e-8ad4-bb0f1f229c46
Copilot AI review requested due to automatic review settings August 6, 2026 12:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 18/18 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10474

No new or modified test methods were identified in the changed regions
of this PR. Nothing to grade.

Re-run with /grade-tests.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · auto · 21.6 AIC · ⌖ 3.3 AIC · ⊞ 16.2K · [◷]( · )

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection results could not be parsed.

Review the workflow run logs for details.

🧵 Parallel-safety audit — PR #10474

Nothing audited here touches process-global state, shared filesystem paths, or [ResourceLock] / [DoNotParallelize] declarations. Nothing to flag for parallel-safety.

Changes reviewed:

  • src/Platform/Microsoft.Testing.Extensions.AzureDevOpsReport/AzureDevOpsLogGroupReporter.cs — pure boolean-logic change (parses --report-azdo-groups); no shared/global state involved.
  • test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AzureDevOpsLogGroupReporterTests.cs — updated/added [TestMethod]s only use per-instance Moq mocks constructed fresh per test (constructor-per-test); no statics, no env/CWD/console mutation.
  • test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/DotnetTestPipe/DotnetTestPipeAzureDevOpsForwardingTests.cs — the TF_BUILD env var is passed via environmentVariables into FakeDotnetTestSdk.RunAsync, which sets it only on the spawned child test-host process (not via Environment.SetEnvironmentVariable on the running test-host), so it does not mutate process-global state.
  • test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs — only a wildcard help-text string updated (default value changed from 'on' to 'off'); no behavioral change.
  • Localization .resx/.xlf files — text-only.

No .runsettings, testconfig.json, .csproj/.props/.targets, or [assembly: Parallelize] / [assembly: DoNotParallelize] changes in this PR.

Audited Microsoft.Testing.Extensions.UnitTests and Microsoft.Testing.Platform.Acceptance.IntegrationTests at scope MethodLevel, workers CPU count (both configured via unchanged [assembly: Parallelize(Scope = ExecutionScope.MethodLevel, Workers = 0)] in their respective Program.cs).

Re-run with /parallel-audit.

🤖 Automated content by GitHub Copilot. Generated by the Parallel-safety audit on PR (on open / sync) workflow. · auto · 133.9 AIC · ⊞ 24.6K · [◷]( · )

@Evangelink
Amaury Levé (Evangelink) merged commit d0a4081 into main Aug 6, 2026
38 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/disable-parallel-azdo-groups branch August 6, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants