Fix profile icon resolution for ICO files - #20659
Draft
DeliberateEnsemble (vortsghost2025) wants to merge 1 commit into
Draft
DeliberateEnsemble (vortsghost2025) wants to merge 1 commit into
DeliberateEnsemble (vortsghost2025) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
NOTE: We do not accept PRs that haven't been tested locally. Please build and run the project. A screenshot of the loaded .ico files would suffice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Route
.icoprofile icon paths through the existingSHDefExtractIcon/WIC conversion path instead ofBitmapIconSource. Windows can then select the icon image matching the requested size rather than using the first image in the.icofile.Fixes #19264
Validation
clang-format --dry-run --Werror --style=file src/cascadia/UIHelpers/IconPathConverter.cppgit diff --checkwithcore.whitespace=cr-at-eolfor the repository's CRLF worktree filesSHDefExtractIconprobe against the issue's multi-resolutiontest.ico: requests for 16, 24, 32, 48, 64, 96, 128, and 256 pixels returned matching image dimensionsA full Visual Studio/MSBuild/TAEF build was not available in this environment.