Merge User-Agent headers when cloning HTTP client#508
Open
heyitsaamir wants to merge 6 commits intomainfrom
Open
Merge User-Agent headers when cloning HTTP client#508heyitsaamir wants to merge 6 commits intomainfrom
heyitsaamir wants to merge 6 commits intomainfrom
Conversation
These two markdown files are all a human needs to write — the e2e testing skill generates and manages the actual Playwright test code from here. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Instead of overwriting, clone() now concatenates User-Agent headers so each layer's identifier is preserved across nested clones. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.clone()now concatenatesUser-Agentheaders instead of overwriting, so each layer's identifier is preserved (e.g.teams.ts[graph]/x.x teams.ts[apps]/x.x)Test plan
npx jest src/http/client.spec.tsfrompackages/common— all 23 tests pass