Integration Tests for Agentic/Bot Identities#408
Draft
Conversation
Introduce agentic identity support in ConversationClientTest by adding helper methods to construct agentic user/app context from environment variables. Update all relevant test methods to use these helpers and pass agentic identity where required. Replace Console.WriteLine with xUnit output integration and configure logging for xUnit. Add MartinCostello.Logging.XUnit package for improved test logging. Mark tests requiring special permissions as skipped, and update logging configuration to use "Microsoft.Teams": "Trace". Includes minor test output and environment variable handling improvements.
Replaced explicit string declarations with var for agenticUserId, agenticAppId, and agenticAppBlueprintId in GetConversationAccountWithAgenticProperties and GetAgenticIdentity methods. This change improves code readability and maintains stylistic consistency. No functional changes were made.
Centralize agentic identity and conversation account construction in new AgenticIdentitiyFromEnv helper. Replace inlined and private methods in test files with calls to this helper. Remove redundant methods from ConversationClientTest. Update TeamsApiClientTests to use ITestOutputHelper for logging and consistently pass agentic identity to TeamsApiClient methods. Improves code reuse, test output, and maintainability.
Explicitly assign Conversation.Id in CoreActivity using the TEST_CONVERSATIONID environment variable, with error handling if not set. This ensures the test message is associated with the correct conversation context.
Enabled group/topic tests, switched to TEST_TENANTID env var, and set Activity.From using agentic identity. Improved test coverage and ensured agentic identity is used in conversation creation and activity sending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the test infrastructure for the Teams Bot SDK by centralizing the construction of agentic identities from environment variables, refactoring test code to use this new approach, and clarifying test requirements. The changes enhance maintainability and make it easier to configure and run tests that require special permissions or agentic identity properties.
Test infrastructure improvements:
AgenticIdentitiyFromEnvto centralize the creation ofConversationAccountandAgenticIdentityinstances using environment variables. This reduces code duplication and simplifies agentic identity management in tests.ConversationClientTestto use the newAgenticIdentitiyFromEnvhelper for constructing agentic identities and conversation accounts, replacing previous inline environment variable usage and property assignments. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Test clarity and maintainability:
[Fact]test attributes inCompatTeamsInfoTests.csto clarify that they require special permissions, improving test documentation and preventing accidental execution without the necessary setup. [1] [2] [3] [4] [5] [6] [7] [8] [9]Logging and output improvements:
Console.WriteLinestatements withITestOutputHelper.WriteLinein tests to ensure test output is properly captured in test logs, aiding in debugging and test analysis. [1] [2] [3] [4]Microsoft.IdentityandMicrosoft.Teamsto show more relevant log levels during test execution.