-
Notifications
You must be signed in to change notification settings - Fork 16
Update quoted replies & new quotes features #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
corinagum
wants to merge
15
commits into
main
Choose a base branch
from
cg/quoted-replies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
00ff15e
Remove WithReplyToId and update ToQuoteReply but mark it obsolete
8e59678
Add quoted replies features and unit tests
17f5f18
Fix up
30f148f
Quoted replies sample
d0fd607
Mark quoted replies experimental
a071e37
Add context-level tests for Reply and QuoteReply
5698b05
Update examples
0ada25c
Address feedback
67934bb
Add XML doc for Time field format (IC3 epoch)
dc99fd5
Refactor Reply to delegate to QuoteReply and gate entity on message type
2955594
Move stamping to model layer
c97e9b4
Update to Quote and verbiage improvements
corinagum 29f63a0
Fix ToQuote() → ToQuoteReply() in sample (compile error)
corinagum f8a8e57
Rename Sample
corinagum 9243e81
Fix
corinagum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
Libraries/Microsoft.Teams.Api/Entities/QuotedReplyEntity.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace Microsoft.Teams.Api.Entities; | ||
|
|
||
| [Experimental("ExperimentalTeamsQuotedReplies")] | ||
| public class QuotedReplyEntity : Entity | ||
| { | ||
| [JsonPropertyName("quotedReply")] | ||
| [JsonPropertyOrder(3)] | ||
| public required QuotedReplyData QuotedReply { get; set; } | ||
|
|
||
| public QuotedReplyEntity() : base("quotedReply") { } | ||
| } | ||
|
|
||
| [Experimental("ExperimentalTeamsQuotedReplies")] | ||
| public class QuotedReplyData | ||
| { | ||
| [JsonPropertyName("messageId")] | ||
| public required string MessageId { get; set; } | ||
|
|
||
|
corinagum marked this conversation as resolved.
|
||
| [JsonPropertyName("senderId")] | ||
| public string? SenderId { get; set; } | ||
|
|
||
| [JsonPropertyName("senderName")] | ||
| public string? SenderName { get; set; } | ||
|
|
||
| [JsonPropertyName("preview")] | ||
| public string? Preview { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Timestamp of the quoted message (IC3 epoch value, e.g. "1772050244572"). | ||
| /// Populated on inbound; ignored on outbound. Absent for deleted quotes. | ||
| /// </summary> | ||
| [JsonPropertyName("time")] | ||
| public string? Time { get; set; } | ||
|
|
||
|
corinagum marked this conversation as resolved.
|
||
| [JsonPropertyName("isReplyDeleted")] | ||
| public bool? IsReplyDeleted { get; set; } | ||
|
|
||
| [JsonPropertyName("validatedMessageReference")] | ||
| public bool? ValidatedMessageReference { get; set; } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.