fix(audio): handle rejected capture stop flush - #93
Open
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 2 commits into
Open
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 2 commits into
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 2 commits into
Conversation
Report a failed final chunk flush over IPC before acknowledging stop. Fixes microsoft#15
|
ANIRUDDHA ADAK (@aniruddhaadak80) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle a rejected final audio chunk flush in the capture preload and surface it to the recorder.
Why
MediaRecorder.onstopwaited onsendChainwithout a rejection handler. A failed final chunk flush could become an unhandled rejection and never tell the main process why the segment failed.Changes
audio:errorfollowed byaudio:stopped.npm test.Testing
npm test(existing suite plus the new regression test; not executed yet)npm run build(existing CI command; not executed yet)Local execution was not performed because this contribution is remote-only; no local checkout or source was used.
The new test is unit-level; it does not replace the full Electron/MediaRecorder matrix run by CI.
CI status
Non-WindowsandWindowsActions runs areaction_requiredwith no jobs or logs; upstream workflow approval is required before the commands can run.license/clawas queued at the last check.Fixes #15