ci: type-check evals in pull request workflow - #92
Open
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Open
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
ANIRUDDHA ADAK (aniruddhaadak80) wants to merge 1 commit into
Conversation
Run the existing eval TypeScript project on the Ubuntu CI leg. The duplicate-run portion of microsoft#6 is intentionally unchanged because the current push trigger is already limited to main. Fixes microsoft#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the existing eval TypeScript project to the Ubuntu leg of the non-Windows workflow.
Why
The root TypeScript configuration excludes
evals, while the existing test and build commands do not type-check that project. Eval type errors could therefore pass CI without running model-backed evals.Changes
npm run typecheck:evalsonly on Linux.pushis currently limited tomain, so this PR does not change triggers or add concurrency.Testing
npm run typecheck:evals(new CI step; not executed yet)npm test(existing CI command; not executed yet)npm run build(existing CI command; not executed yet)Local execution was not performed because this contribution is remote-only; no local checkout or source was used.
CI status
Non-WindowsandWindowsActions runs areaction_requiredwith no jobs or logs; upstream workflow approval is required before the commands can run.license/clapassed.Fixes #6