Skip to content

Make ACP model-selection integration test resilient to removed models #1439

Description

@duffney

Problem

The coder-acp-copilot integration test hard-codes TEST_MODEL=claude-opus-4.6. The current ACP session still advertises model-selection capability, but that model is no longer present in models.availableModels.

selectModel() logs that the requested model is unavailable, attempts session/set_model, catches the rejection, and returns undefined. The test then assumes undefined means model-selection capability was not advertised and requires this different warning:

does not advertise model selection capability

The actual warning is:

session/set_model failed for "claude-opus-4.6"

As a result, the coding prompt succeeds but the model-selection assertion fails.

Expected behavior

The integration test should remain meaningful without depending on a server-controlled model identifier that may be removed independently of the pinned CLI version.

Prefer selecting a non-default model from the session's advertised available-model list and asserting that selection succeeds. A short-term constant update may unblock the test, but dynamic selection is the durable fix.

Related work

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions