fix: persist comprehensive Trivy secrets and misconfigs - #86
Closed
Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Closed
fix: persist comprehensive Trivy secrets and misconfigs#86Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Conversation
Comprehensive scans counted secrets/misconfigurations but never built SecurityFindings, so the security_findings table stayed empty and detail reports could not surface them. Map Trivy secrets and misconfigs into domain findings, store them on the image record, load them (and capabilities) in QueryAllImageDetails, and emit them in the detailed JSON report. Fixes microsoft#73
Abhinesh Jha (Abhineshhh)
requested review from
Dariusz Porowski (DariuszPorowski) and
Mani Bindra (maniSbindra)
as code owners
July 16, 2026 19:58
3 tasks
Contributor
Author
|
Closing in favor of a consolidated stack to avoid multi-PR conflicts on the same files. Superseded by consolidated Trivy stack (security findings are included there). Please review the replacement PR linked above (Trivy stack or registry stack). |
Contributor
Author
|
Replacement: #87 (Trivy stack). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comprehensive scans counted secrets/misconfigurations but never built
SecurityFindings, so thesecurity_findingstable stayed empty and detail reports could not surface them — despite schema, InsertImage support, and docs claiming otherwise.Related Issue
Fixes #73
Changes
finding_type=secretand misconfigs →misconfigurationImageRecordduring analysisQueryAllImageDetailssecurityFindingsandcapabilitiesin the detailed JSON reportdocs/detailed-report.mdChecklist
task lintpasses locallytask testpasses locally