fix: parse digest-pinned refs and host:port registries correctly - #83
Closed
Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Closed
fix: parse digest-pinned refs and host:port registries correctly#83Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Conversation
ExtractRegistryAndRepo previously split on the first :, which mangled digest suffixes (@sha256:...) and registries with ports (localhost:5000). Strip digests first and use the last : after the last / as the tag separator, matching Docker reference parsing. Fixes microsoft#74
Abhinesh Jha (Abhineshhh)
requested review from
Dariusz Porowski (DariuszPorowski) and
Mani Bindra (maniSbindra)
as code owners
July 16, 2026 19:58
3 tasks
Contributor
Author
|
Closing in favor of a consolidated stack to avoid multi-PR conflicts on the same files. Superseded by consolidated registry stack (ExtractRegistryAndRepo is included there). Please review the replacement PR linked above (Trivy stack or registry stack). |
Contributor
Author
|
Replacement: #88 (registry stack). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ExtractRegistryAndReposplit on the first:, mangling digest suffixes (@sha256:...) and registries with ports (localhost:5000).Related Issue
Fixes #74
Changes
@digestbefore parsing:after last/as tag separatorChecklist
task lintpasses locallytask testpasses locally