Skip to content

fix: use Trivy --scanners instead of deprecated --security-checks #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Abhinesh Jha (Abhineshhh) wants to merge 1 commit into from
Closed

fix: use Trivy --scanners instead of deprecated --security-checks #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions pkg/infrastructure/scanner/trivy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ type trivyOS struct {
}

type trivyResult struct {
Target string `json:"Target"`
Class string `json:"Class"`
Type string `json:"Type"`
Vulnerabilities []trivyVuln `json:"Vulnerabilities"`
Secrets []trivySecret `json:"Secrets"`
Misconfigs []trivyMisconfig `json:"Misconfigurations"`
Licenses []trivyLicense `json:"Licenses"`
Target string `json:"Target"`
Class string `json:"Class"`
Type string `json:"Type"`
Vulnerabilities []trivyVuln `json:"Vulnerabilities"`
Secrets []trivySecret `json:"Secrets"`
Misconfigs []trivyMisconfig `json:"Misconfigurations"`
Licenses []trivyLicense `json:"Licenses"`
}

type trivyCVSS struct {
Expand Down Expand Up @@ -96,14 +96,16 @@ type trivyLicense struct {
func RunTrivy(imageName string, comprehensive bool) (*domain.TrivyResult, error) {
log.Infof("Running Trivy on: %s (comprehensive=%v)", imageName, comprehensive)

securityChecks := "vuln"
// Prefer --scanners (Trivy renamed --security-checks). Use "misconfig"
// rather than the deprecated "config" scanner name.
scanners := "vuln"
if comprehensive {
securityChecks = "vuln,secret,config"
scanners = "vuln,secret,misconfig"
}

cmd := exec.Command("trivy", "image",
"--format", "json",
"--security-checks", securityChecks,
"--scanners", scanners,
imageName,
)

Expand Down