Convert to package spans when lowering from HIR to FIR - #3664
Merged
Conversation
Ian Davis (idavis)
requested review from
Andrew Casey (amcasey) and
Stefan J. Wernli (swernli)
as code owners
August 27, 2026 20:17
Stefan J. Wernli (swernli)
approved these changes
Aug 27, 2026
Stefan J. Wernli (swernli)
left a comment
Stefan J. Wernli (swernli)
left a comment
Contributor
There was a problem hiding this comment.
Left a few comments on places to ensure the package id from the upgraded PackageSpan is used rather than some other package id since now we know the one inside the PackageSpan is more trustworthy. Thanks for working on this!
Ian Davis (idavis)
force-pushed
the
iadavis/package-span-lowering
branch
from
August 31, 2026 14:33
4db3745 to
31d8c9c
Compare
Stefan J. Wernli (swernli)
force-pushed
the
iadavis/package-span-lowering
branch
from
September 2, 2026 16:54
31d8c9c to
25db5f2
Compare
Stefan J. Wernli (swernli)
force-pushed
the
iadavis/package-span-lowering
branch
from
September 2, 2026 17:00
25db5f2 to
37074ce
Compare
Stefan J. Wernli (swernli)
requested review from
Scott Carda (ScottCarda-MS) and
Bill Ticehurst (billti)
as code owners
September 2, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.