Use once_cell to cache stdlib compilation in wasm#124
Merged
Conversation
Collaborator
Author
|
Of note for those keeping track of what dependencies we are pulling in: the |
idavis
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds simple caching of the stdlib compilation during check calls using OnceCell. Since the stdlib is static in the wasm layer and the store does not need to be mutable (the compilation unit for the checked user's code is not added to it), this can be done once for the lifetime of the loaded package and reused over and over. In local testing, this produced a 95% perf improvement on the check calls performed as the user types (from 2.3 ms to 0.1 ms).