Repository navigation
Report deferred primer and benchmark checks on PR heads - #11847
Conversation
Queue PR-visible follow-up checks while Validation runs, report execution results from trusted jobs, and run mypy_primer for every validated PR. Keep the benchmark analyzer filter and branch protection unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
|
Result: Verification detailsVerification: Isolated verification observed failures whose relationship to this PR could not be determined: Dependency and test discovery; this review is not fully verified. Summary: All 31 targeted benchmark-comparison tests passed, including the PR's executable workflow guards and new lifecycle test. Changed-file ESLint and Prettier checks passed, and six additional failed-Validation reporting scenarios passed. Initial discovery failed because Git metadata and installed YAML dependencies were unavailable; the offline dependency bootstrap succeeded. Local verification is strong, but hosted GitHub Actions execution and the claimed full 72-test benchmark suite were not verified. Test runs: 5 passed, 1 failed
❌
|
|
Existing review feedback remains actionable. |
|
Copilot resolve the merge conflicts in this pull request |
# Conflicts: # .github/workflows/typecheck_benchmark_trigger.yml Co-authored-by: bschnurr <1946977+bschnurr@users.noreply.github.com>
Merged |
|
Result: Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: Batched dependency and test discovery. Summary: All 32 tests in the changed comparator/workflow suite passed, including the new check-lifecycle test and expanded path-filter coverage. Offline dependency installation, changed-file ESLint, and Prettier checks passed. An additional mocked workflow test passed 12 failed-Validation scenarios covering both checks and stale-head rejection. Discovery Git probes failed because the container snapshot lacked Git metadata; live GitHub Actions execution was not verified. Test runs: 5 passed, 1 failed
❌
|
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Summary
mypy_primerandType checker benchmarkchecks on the PR head instead of leaving their nativeworkflow_runchecks attached tomain.Review and verification
Reviewed the complete workflow change set and made check start/completion timestamps explicit. All 72 existing benchmark tests pass, including executable YAML guards for lifecycle, filters, reporting outcomes, and permissions. Changed-file ESLint and Prettier checks pass.
Addresses the missing PR-visible checks observed on #11839.