Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/pyright-internal/src/analyzer/typedDicts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -953,10 +953,9 @@ export function getTypedDictDictEquivalent(

let dictValueType = entries.extraItems.valueType;

let isEquivalentToDict = true;
entries.knownItems.forEach((entry) => {
for (const entry of entries.knownItems.values()) {
if (entry.isReadOnly || entry.isRequired) {
isEquivalentToDict = false;
return undefined;
}

dictValueType = combineTypes([dictValueType, entry.valueType]);
Expand All @@ -971,12 +970,8 @@ export function getTypedDictDictEquivalent(
recursionCount + 1
)
) {
isEquivalentToDict = false;
return undefined;
}
});

if (!isEquivalentToDict) {
return undefined;
}

return dictValueType;
Expand Down
Loading