Repository navigation
Short-circuit isTypeVarSame subtype checks #11681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bill Schnurr (bschnurr)
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
bschnurr:perf/type-utils-short-circuit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c49ce2f
Short-circuit isTypeVarSame subtype checks
bschnurr abc8605
Merge main into perf/type-utils-short-circuit
bschnurr 039d0e1
Merge main into perf/type-utils-short-circuit
bschnurr 299baaa
Merge upstream/main into PR 11681
bschnurr 7603cc8
Preserve unary callbacks in allSubtypes
bschnurr 6191331
Merge upstream/main into PR 11681
bschnurr 82c1872
Keep subtype tests before helper declarations
bschnurr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move both new tests above the existing file-scoped helper section. Appending tests after
createFunction,createClass, andreplacePairviolatesdocs/pylancewiki/review/tests-helper-placement.md, which requires helpers at the end of their scope.