Skip to content

fix(webview): also invoke Network.setExtraHTTPHeaders during session init#41389

Open
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-WKWebView-setExtraHTTPHeaders
Open

fix(webview): also invoke Network.setExtraHTTPHeaders during session init#41389
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-WKWebView-setExtraHTTPHeaders

Conversation

@dcrousso

Copy link
Copy Markdown
Contributor

No description provided.

@dcrousso dcrousso requested review from pavelfeldman and yury-s June 19, 2026 21:46
@dcrousso dcrousso added the CQ1 label Jun 19, 2026
@dcrousso dcrousso changed the title fix(webview): also invoke setExtraHTTPHeaders during session init fix(webview): also invoke NetworksetExtraHTTPHeaders during session init Jun 19, 2026
@dcrousso dcrousso changed the title fix(webview): also invoke NetworksetExtraHTTPHeaders during session init fix(webview): also invoke Network.setExtraHTTPHeaders during session init Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

7354 passed, 1122 skipped


Merge workflow run.

@yury-s yury-s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we now unskip more tests?

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-page] › page/workers.spec.ts:40 › should emit created and destroyed events @firefox-ubuntu-22.04-node20

5 flaky ⚠️ [chromium-library] › library/video.spec.ts:113 › screencast › should capture static page `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context @smoke `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:645 › screencast › should capture full viewport `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:717 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:717 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`

48906 passed, 1142 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

10 failed
❌ [chromium-library] › library/heap.spec.ts:203 › cycle handles @chromium-macos-15-large
❌ [chromium-page] › page/page-evaluate.spec.ts:582 › should transfer 100Mb of data from page to node.js @chromium-macos-15-large
❌ [firefox-page] › page/workers.spec.ts:40 › should emit created and destroyed events @tracing-firefox
❌ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:111 › should restore state from userDataDir @firefox-macos-15-large
❌ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:264 › user agent is up to date @firefox-macos-15-large
❌ [firefox-library] › library/heap.spec.ts:203 › cycle handles @firefox-macos-15-large
❌ [firefox-library] › library/proxy.spec.ts:235 › should exclude patterns @firefox-macos-15-large
❌ [firefox-page] › page/workers.spec.ts:40 › should emit created and destroyed events @firefox-macos-15-large
❌ [firefox-page] › page/workers.spec.ts:40 › should emit created and destroyed events @firefox-windows-latest
❌ [firefox-page] › page/workers.spec.ts:40 › should emit created and destroyed events @firefox-macos-15-xlarge

35 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:371 › should produce network events, routing, and annotations for Service Worker `@tracing-chromium`
⚠️ [chromium-library] › library/video.spec.ts:645 › screencast › should capture full viewport `@tracing-chromium`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@msedge-windows-latest`
⚠️ [chromium-library] › library/har.spec.ts:109 › should populate entry startedDateTime from the browser `@chromium-macos-15-large`
⚠️ [chromium-library] › library/heap.spec.ts:106 › should not leak dispatchers after closing page `@chromium-macos-15-large`
⚠️ [chromium-page] › page/page-filechooser.spec.ts:24 › should upload multiple large files `@chromium-macos-15-large`
⚠️ [chromium-library] › library/screenshot.spec.ts:213 › page screenshot › should not hang when event loop is blocked `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:150 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:680 › screencast › should capture full viewport on hidpi `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:431 › launchServer › should reject waitForEvent before browser.close finishes `@chrome-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-base-url.spec.ts:37 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto `@firefox-macos-15-large`
⚠️ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:139 › should create userDataDir if it does not exist `@firefox-macos-15-large`
⚠️ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:180 › should have passed URL when launching with ignoreDefaultArgs: true `@firefox-macos-15-large`
⚠️ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:246 › should connect to a browser with the default page `@firefox-macos-15-large`
⚠️ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:271 › dialog.accept should work `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in nunit if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › should not print context options method override in mstest if no options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in xunit if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:245 › should print a valid basic program in mstest `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:271 › should print a valid basic program in nunit `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-java.spec.ts:125 › should print a valid basic program in junit `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-javascript.spec.ts:84 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-pytest.spec.ts:49 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-python-async.spec.ts:80 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-python.spec.ts:76 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/proxy.spec.ts:144 › should authenticate `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:170 › should make a copy of default viewport `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:117 › reuse connect › should reset serviceworker `@tracing-webkit`
⚠️ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:100 › should print the correct context options when using a device and additional options `@webkit-windows-latest`
⚠️ [android-page] › page/selectors-frame.spec.ts:209 › should click in lazy iframe

104500 passed, 4403 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants