Skip to content

feat(webview): support page.requestGC #41388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcrousso wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −7
Open

feat(webview): support page.requestGC #41388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/playwright-core/src/server/webkit/webview/wvPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ export class WVPage implements PageDelegate {
throw new Error('Method not implemented.');
}

requestGC(): Promise<void> {
throw new Error('Method not implemented.');
async requestGC(): Promise<void> {
await this._session.send('Heap.gc');
}

updateFileChooserInterception(): Promise<void> {
Expand Down
5 changes: 0 additions & 5 deletions tests/webview/expectations/webkit-webview-page.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,6 @@ page/page-history.spec.ts › page.goForward during renderer-initiated navigatio
page/page-history.spec.ts › page.reload should work on a page with a hash [fail]
page/page-history.spec.ts › page.reload should work with cross-origin redirect [fail]
page/page-history.spec.ts › should reload proper page [fail]
page/page-leaks.spec.ts › click should not leak [fail]
page/page-leaks.spec.ts › expect should not leak [fail]
page/page-leaks.spec.ts › fill should not leak [fail]
page/page-leaks.spec.ts › waitFor should not leak [fail]
page/page-localstorage.spec.ts › storage methods are scoped to the current origin [fail]
page/page-mouse.spec.ts › should pointerdown the div with a custom button [fail]
page/page-mouse.spec.ts › should select the text with mouse [fail]
Expand Down Expand Up @@ -482,7 +478,6 @@ page/page-emulate-media.spec.ts › should emulate contrast [fail]
page/page-emulate-media.spec.ts › should emulate forcedColors [fail]
page/page-emulate-media.spec.ts › should emulate type @smoke [fail]
page/page-emulate-media.spec.ts › should work during navigation [fail]
page/page-request-gc.spec.ts › should work [fail]
page/page-request-intercept.spec.ts › should fulfill intercepted response using alias [fail]
page/page-request-intercept.spec.ts › should intercept with url override [fail]
page/page-request-intercept.spec.ts › should not follow redirects when maxRedirects is set to 0 in route.fetch [fail]
Expand Down
Loading