feat(webview): support page.emulateMedia#41386
Open
dcrousso wants to merge 1 commit into
Open
Conversation
yury-s
approved these changes
Jun 19, 2026
| const contextOptions = this._browserContext._options; | ||
| if (contextOptions.userAgent) | ||
| promises.push(this.updateUserAgent()); | ||
| const emulatedMedia = this._page.emulatedMedia(); |
Member
There was a problem hiding this comment.
Why did this part change? I assume it's redundant with the updateEmulateMedia removed below, if so, can we just drop this part or the order matters here?
Contributor
Author
There was a problem hiding this comment.
yeah this was just something i noticed when looking at this file for reference
i thought it looked cleaner to use updateEmulateMedia (which btw does the exact same thing) and to prefer the earlier callsite since that can have more of an effect (e.g. if the developer checks media state in their bootstrap script)
Contributor
Author
There was a problem hiding this comment.
actually there is a difference. this is just dealing with a specific session whereas updateEmulateMedia deals with all of them
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dcrousso
force-pushed
the
fix-WKWebView-emulateMedia
branch
from
b5f33ef to
df2ed7a
Compare
dcrousso
force-pushed
the
fix-WKWebView-emulateMedia
branch
from
df2ed7a to
e8b722f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"7354 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 2"5 failed 33 flaky104490 passed, 4400 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 6 flaky48905 passed, 1142 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.