chore(bidi): fix redirected navigations from HAR routers#41377
Open
hbenl wants to merge 1 commit into
Open
Conversation
hbenl
force-pushed
the
har-redirected-navigation
branch
from
1869dbf to
1d33e85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For redirected navigations from HAR routers to be handled correctly,
navigateFrame()needs to throw aNavigationAbortedErrorcontaining the correctdocumentId. Unfortunately the Bidi error forbrowsingContext.navigatedoesn't contain it so we need to take it from the precedingbrowsingContext.navigationFailedevent.Fixes the following tests in
library/browsercontext-har.spec.ts:"should goForward to redirected navigation"(this one's still flaky due to Bug 1987774)