Skip to content

Conversation

@benhillis
Copy link
Member

@benhillis benhillis requested a review from a team as a code owner February 4, 2026 22:25
Copilot AI review requested due to automatic review settings February 4, 2026 22:25
@github-actions github-actions bot added the release_1.7.2511 Targets the release/1.7.2511 branch. label Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mirror pipeline configuration for the OpenHCL 1.7 (release/1.7.2511) branch to reflect its transition into "Ask Mode" - the final scrutiny phase before release closure where only critical fixes are allowed.

Changes:

  • Modified the mirror pipeline to update the staging branch (staging/1.7.2511) instead of the release branch (release/1.7.2511) while still mirroring from the release branch

build = {
'definition': {'id': pipeline_id},
'templateParameters': {'branchToMirror': 'release/1.7.2511', 'branchToUpdateSubmodule': 'release/1.7.2511', 'updateSubmodule': 'true'},
'templateParameters': {'branchToMirror': 'release/1.7.2511', 'branchToUpdateSubmodule': 'staging/1.7.2511', 'updateSubmodule': 'true'},
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description references the Ask Mode documentation at https://openvmm.dev/guide/dev_guide/contrib/release.html, but this documentation does not explain the concept of staging branches or the workflow change where 'branchToUpdateSubmodule' differs from 'branchToMirror' during Ask Mode. Consider updating the release documentation to explain this pattern so future maintainers understand when and why to use staging branches.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_1.7.2511 Targets the release/1.7.2511 branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants