Pass metrics observations to upstream SDKStats Manager#191
Open
rads-1996 wants to merge 3 commits into
Open
Conversation
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the distro’s SDKStats “network” metric integration so that OTLP/Agent365 request-success counts are contributed to the upstream Azure Monitor Statsbeat metric stream via StatsbeatManager.add_metric_callback, rather than by mutating upstream observable gauge callback lists directly.
Changes:
- Refactors network SDKStats integration to register an additional observation callback through
StatsbeatManager.add_metric_callback. - Updates module documentation/wording to reflect “observations” rather than “gauges”.
- Removes the prior thread-safe idempotency guard and test reset helper (impacting existing test expectations).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.