Add OutputFixPass and NameFixPass in optimize #2779
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
requested review from
Copilot,
gramalingam and
titaiwangms
and removed request for
Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
=======================================
Coverage 70.45% 70.45%
=======================================
Files 228 228
Lines 27257 27257
Branches 2760 2760
=======================================
Hits 19203 19203
Misses 7102 7102
Partials 952 952 ☔ View full report in Codecov by Sentry. |
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Jan 23, 2026
Move optimization logic to the internal export() call and move io renaming to after it such that, combined with microsoft/onnxscript#2779, the model will be correct with proper input output names in edge cases. Fixes pytorch#173076 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added
merge at lgtm
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 24, 2026
Move optimization logic to the internal export() call and move io renaming to after it such that, combined with microsoft/onnxscript#2779, the model will be correct with proper input output names in edge cases. Fixes #173076 Pull Request resolved: #173185 Approved by: https://github.com/xadupre, https://github.com/titaiwangms, https://github.com/cyyever
titaiwangms
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pytorch/pytorch#168211 Fix pytorch/pytorch#167848 Partially address pytorch/pytorch#173076