Add stacktrace in metadata_props for rewriter created nodes #2423
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 69.29% 69.30%
=======================================
Files 202 202
Lines 25773 25778 +5
Branches 2688 2688
=======================================
+ Hits 17860 17865 +5
Misses 6988 6988
Partials 925 925 ☔ View full report in Codecov by Sentry. |
| num_outputs = outputs | ||
|
|
||
| metadata_props = { | ||
| "pkg.onnxscript.rewriter.stacktrace": _get_stacktrace(), |
There was a problem hiding this comment.
Should this always be added? Or, would it be better to do it only if the user sets some config/environment variable?
There was a problem hiding this comment.
I think it's ok as a default? For example torch.export will add metadata as well. If user wants no stack traces they can run a pass, or if there's demand we can add an option to turn it off?
There was a problem hiding this comment.
But who's using this? What happens when multiple rewrites happen? Trying to understand what exactly the use-case is and what the users want.
There was a problem hiding this comment.
When we look at the graph from pytorch, all nodes can be traced back from source code in the torch model, but it is unclear which rule created the nodes that are added by the rewriter. So I was trying to add this information. A node can only be created once so multiple rewrites should not affect this field
No description provided.