Skip to content

nvx-rs: drop the guest::clone alias and the code that stale dead-code expectations hid #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pedro Henrique Penna (ppenna) merged 4 commits into from
Nov 13, 2026
Merged

nvx-rs: drop the guest::clone alias and the code that stale dead-code expectations hid #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac572dd
guest: drop guest::clone, the alias of guest::activation
ppenna Nov 13, 2026
782453f
guest: delete what only the exec core's tests used
ppenna Nov 13, 2026
80f072e
guest: hold the switched layered root without a dead-code expectation
ppenna Nov 13, 2026
c251d84
host: drop the VM directory's copies of the snapshot names
ppenna Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ changed item to its replacement, or to what its caller now does.
- **No exec.** The exec engine, `nvx::exec`, and the guest's process modules,
`nvx::guest::{exec, spawn, process, cgroup, entry}`, are gone. A guest's init
runs its executions itself.
- **`nvx::guest::clone` is `nvx::guest::activation`.** The old name is gone.
- **The guest's space is private.** nvx-init's space, `nvx::guest::{root, gpt}`
and the mapper of `nvx::guest::mappings`, is private to `nvx`.
`resolve_guest_path` is gone, and `ExportPlan` holds paths only.
Expand Down
2 changes: 1 addition & 1 deletion doc/migrate-from-alpha.7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ keeps its path and its signature.

| alpha.7 | The release |
| --- | --- |
| `guest::clone` | `guest::activation`, which `guest::clone` still names. Its `CaptureCause` and `CaptureStage` have a new `Repair` variant |
| `guest::clone` | `guest::activation`: the old name is gone. Its `CaptureCause` and `CaptureStage` have a new `Repair` variant |
| `guest::clone`'s `CapturePreparation`, `CaptureBarrier`, `AdmissionFence`, `CaptureError`, `Captured`, `Devices`, `Repair`, `Restored`, and `repair` | `guest::snapshot::capture(&devices, disks, deadline)`, one call that checks the devices, captures, and, in a VM that a restore started, repairs the restore before it returns `Captured::Restored`. A `CaptureFailure` says whether the guest resumed or must end. The init stops its own executions first, as [Coordinate a capture](guest-agent-guidelines.md#coordinate-a-capture) describes |
| `guest::clone::Activation::new`, `guest::clone::Activation::with_resources` | Take no admission fence: `guest::activation::Activation::new(&repaired, timeout, now)` |
| `guest::clone`'s `apply`, `Applied`, `ApplyError`, `AppliedTeardownError`, `NetworkError`, and `RootTemplate` | No longer public: the init applies a restore's activation record in its own space, as [Complete a restore before Ready](guest-agent-guidelines.md#complete-a-restore-before-ready) describes |
Expand Down
4 changes: 2 additions & 2 deletions nvx-rs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,8 +882,8 @@ the activation record.

x86_64: the activation of each clone that a restore of a snapshot starts, once
`nvx::guest::snapshot::capture` repaired it, for a guest init or agent, whether
or not it is PID 1. `nvx::guest::clone` remains a compatibility alias.
Activation itself holds no admission fence and starts no process.
or not it is PID 1. Activation itself holds no admission fence and starts no
process.

In a clone, the capture repairs the restore before it returns: it checks that
the online CPUs are a prefix that the restore's processor target does not
Expand Down
144 changes: 0 additions & 144 deletions nvx-rs/public-api/linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,150 +420,6 @@ method nvx::guest::activation::Repaired::acknowledged_at
method nvx::guest::activation::Repaired::cpus
method nvx::guest::activation::Repaired::generation_id
method nvx::guest::activation::Repaired::memory
mod nvx::guest::clone
struct nvx::guest::clone::Activation
method nvx::guest::clone::Activation::complete
method nvx::guest::clone::Activation::deadline
method nvx::guest::clone::Activation::established
method nvx::guest::clone::Activation::input
method nvx::guest::clone::Activation::new
method nvx::guest::clone::Activation::start
method nvx::guest::clone::Activation::state
method nvx::guest::clone::Activation::tick
method nvx::guest::clone::Activation::with_resources
enum nvx::guest::clone::ActivationAction
variant nvx::guest::clone::ActivationAction::Acknowledge
variant nvx::guest::clone::ActivationAction::Apply
field nvx::guest::clone::ActivationAction::Apply::0
variant nvx::guest::clone::ActivationAction::Continue
variant nvx::guest::clone::ActivationAction::Join
variant nvx::guest::clone::ActivationAction::Ready
field nvx::guest::clone::ActivationAction::Ready::0
variant nvx::guest::clone::ActivationAction::Serve
enum nvx::guest::clone::ActivationCause
variant nvx::guest::clone::ActivationCause::Changed
variant nvx::guest::clone::ActivationCause::Cold
variant nvx::guest::clone::ActivationCause::Completion
variant nvx::guest::clone::ActivationCause::Expired
variant nvx::guest::clone::ActivationCause::Failed
field nvx::guest::clone::ActivationCause::Failed::0
variant nvx::guest::clone::ActivationCause::Record
field nvx::guest::clone::ActivationCause::Record::0
variant nvx::guest::clone::ActivationCause::Request
variant nvx::guest::clone::ActivationCause::Reset
variant nvx::guest::clone::ActivationCause::Resources
field nvx::guest::clone::ActivationCause::Resources::actual
field nvx::guest::clone::ActivationCause::Resources::expected
variant nvx::guest::clone::ActivationCause::Start
variant nvx::guest::clone::ActivationCause::Transaction
field nvx::guest::clone::ActivationCause::Transaction::accepted
field nvx::guest::clone::ActivationCause::Transaction::offered
struct nvx::guest::clone::ActivationFailure
method nvx::guest::clone::ActivationFailure::cause
method nvx::guest::clone::ActivationFailure::state
enum nvx::guest::clone::ActivationInput
variant nvx::guest::clone::ActivationInput::Activate
field nvx::guest::clone::ActivationInput::Activate::0
variant nvx::guest::clone::ActivationInput::Flow
variant nvx::guest::clone::ActivationInput::Request
variant nvx::guest::clone::ActivationInput::Reset
variant nvx::guest::clone::ActivationInput::TooLong
field nvx::guest::clone::ActivationInput::TooLong::0
enum nvx::guest::clone::ActivationState
variant nvx::guest::clone::ActivationState::Activating
variant nvx::guest::clone::ActivationState::Bootstrap
variant nvx::guest::clone::ActivationState::Failed
variant nvx::guest::clone::ActivationState::Ready
variant nvx::guest::clone::ActivationState::Restricted
variant nvx::guest::clone::ActivationState::Started
enum nvx::guest::clone::CaptureCause
variant nvx::guest::clone::CaptureCause::Io
field nvx::guest::clone::CaptureCause::Io::0
variant nvx::guest::clone::CaptureCause::Mounted
field nvx::guest::clone::CaptureCause::Mounted::0
variant nvx::guest::clone::CaptureCause::Pending
variant nvx::guest::clone::CaptureCause::Repair
field nvx::guest::clone::CaptureCause::Repair::0
variant nvx::guest::clone::CaptureCause::Time
field nvx::guest::clone::CaptureCause::Time::0
enum nvx::guest::clone::CaptureStage
variant nvx::guest::clone::CaptureStage::BootChecks
variant nvx::guest::clone::CaptureStage::Capture
variant nvx::guest::clone::CaptureStage::CaptureChecks
variant nvx::guest::clone::CaptureStage::Fence
variant nvx::guest::clone::CaptureStage::GenerationId
variant nvx::guest::clone::CaptureStage::Mounts
variant nvx::guest::clone::CaptureStage::Release
variant nvx::guest::clone::CaptureStage::Repair
variant nvx::guest::clone::CaptureStage::Suppression
const nvx::guest::clone::MACHINE_ID_FILE
const nvx::guest::clone::MOUNT_TABLE_LIMIT
struct nvx::guest::clone::Mounted
method nvx::guest::clone::Mounted::mount_point
method nvx::guest::clone::Mounted::origin
enum nvx::guest::clone::Origin
variant nvx::guest::clone::Origin::Distro
variant nvx::guest::clone::Origin::Filesystem
variant nvx::guest::clone::Origin::Overlay
variant nvx::guest::clone::Origin::Scratch
const nvx::guest::clone::RESOLVER_FILE
enum nvx::guest::clone::RangeFault
variant nvx::guest::clone::RangeFault::Aperture
variant nvx::guest::clone::RangeFault::Extra
variant nvx::guest::clone::RangeFault::Gap
variant nvx::guest::clone::RangeFault::Misaligned
variant nvx::guest::clone::RangeFault::Overlap
enum nvx::guest::clone::RepairCause
variant nvx::guest::clone::RepairCause::Activation
field nvx::guest::clone::RepairCause::Activation::online
field nvx::guest::clone::RepairCause::Activation::target
variant nvx::guest::clone::RepairCause::BlockSize
field nvx::guest::clone::RepairCause::BlockSize::0
variant nvx::guest::clone::RepairCause::CapturedRam
variant nvx::guest::clone::RepairCause::Finished
variant nvx::guest::clone::RepairCause::Incomplete
variant nvx::guest::clone::RepairCause::Io
field nvx::guest::clone::RepairCause::Io::0
variant nvx::guest::clone::RepairCause::Missing
field nvx::guest::clone::RepairCause::Missing::0
variant nvx::guest::clone::RepairCause::NoSeed
variant nvx::guest::clone::RepairCause::Offline
field nvx::guest::clone::RepairCause::Offline::block
field nvx::guest::clone::RepairCause::Offline::state
variant nvx::guest::clone::RepairCause::OnlineCpus
field nvx::guest::clone::RepairCause::OnlineCpus::0
variant nvx::guest::clone::RepairCause::ProcessorTarget
field nvx::guest::clone::RepairCause::ProcessorTarget::online
field nvx::guest::clone::RepairCause::ProcessorTarget::target
variant nvx::guest::clone::RepairCause::Range
field nvx::guest::clone::RepairCause::Range::fault
field nvx::guest::clone::RepairCause::Range::index
variant nvx::guest::clone::RepairCause::Reseed
field nvx::guest::clone::RepairCause::Reseed::0
variant nvx::guest::clone::RepairCause::Time
field nvx::guest::clone::RepairCause::Time::0
variant nvx::guest::clone::RepairCause::UntargetedRanges
struct nvx::guest::clone::RepairError
method nvx::guest::clone::RepairError::cause
method nvx::guest::clone::RepairError::progress
method nvx::guest::clone::RepairError::stage
method nvx::guest::clone::RepairError::status
struct nvx::guest::clone::RepairProgress
method nvx::guest::clone::RepairProgress::added
method nvx::guest::clone::RepairProgress::finish_started
method nvx::guest::clone::RepairProgress::onlined
method nvx::guest::clone::RepairProgress::reseeded
enum nvx::guest::clone::RepairStage
variant nvx::guest::clone::RepairStage::Finish
variant nvx::guest::clone::RepairStage::Memory
variant nvx::guest::clone::RepairStage::Processors
variant nvx::guest::clone::RepairStage::Reseed
variant nvx::guest::clone::RepairStage::Restore
struct nvx::guest::clone::Repaired
method nvx::guest::clone::Repaired::acknowledged_at
method nvx::guest::clone::Repaired::cpus
method nvx::guest::clone::Repaired::generation_id
method nvx::guest::clone::Repaired::memory
mod nvx::guest::console_pending (hidden)
fn nvx::guest::console_pending::main (hidden)
mod nvx::guest::device_io (hidden)
Expand Down
Loading
Loading