[Pedro Henrique Penna (ppenna)]

Leaving code only. This PR changes only code that this effort removes from NVX: the test adapter (tests/runtime-adapter), its runner, and its CI jobs and gates, with the edits that remove references to it. Nothing that stays changes, and no later PR uses what it changes, so the size limits for kept code don't apply.

Part of #1119 (SL5.2, "The 44K-line test adapter is gone"). Parent #1086, umbrella #1076.

Needs SL5.1c (#1118, "Snapshots work end to end on real VMs"): it merged as #1500, after SL5.1b (#1496), and this branch is rebased onto both, at 99d20220. Their smoke tests, which the case matrix names as the coverage of the adapter's rewritten tests, ran and passed in this pull request's CI on KVM, MSHV and WHP.

#859 (the runtime adapter's consumer-contract scenarios C2, C3, C6 and C7 on real VMs) is closed as not planned, now that #816 is rescoped; the adapter's deletion is tracked in #1119, which this PR completes.

What and why

The case matrix, doc/acceptance-case-matrix.md, gives each test of the runtime adapter a fate, and the acceptance that replaces the adapter runs on real VMs (SL5.1a to SL5.1c, #1118). So the adapter goes, consumers first:

• CI stops building, running and gating on it (first commit).
  • ci.yml: distro-artifacts no longer builds and uploads the adapter's guest agent; the WHP job of its scenarios, nvx-microvm-adapter-whp, is gone, and the KVM and MSHV guest and sandbox jobs no longer set runtime-adapter; Required status check, Publish development release and Record performance results stop waiting for that job.
  • run-nvx-microvm-tests.yml: the runtime-adapter selector goes, with the adapter's build, download and scenario steps, and the download of the Ubuntu distro layer for the adapter alone. The default suite and the uploads of failure logs and duration reports take back the conditions that they had before that selector (73b168a).
  • check-nvx-rs no longer checks the adapter's protocol-only, host-only and guest-only configurations; validate-nvx no longer checks test-runtime-adapter --help.
  • scripts/nvx_tools/ci.py: check-required-ci no longer requires the adapter's job, and the change classifier no longer counts tests/runtime-adapter/ among the inputs of the microVM tests.
  • The tests of CI's wiring follow the matrix: the three that only checked the adapter's wiring retire, with RuntimeAdapterSuiteTests' test of the suite's CI steps; the six that stay lose their adapter parts (see Changes to existing tests).
  • doc/ci.md, doc/contribute.md, the repository instructions, the setup workflow's comment and the OpenVMM promotion skill stop describing the adapter's jobs and checks. The measurement that moved WHP's adapter scenarios to a job of their own (ci: shorten the runs that restore the VMM tests or skip both OpenVMM suites #982) goes with that job, and the paragraphs that it changed take back their wording from before it.
• The adapter and its runner go (second commit): tests/runtime-adapter (its manifest, lockfile, README, scenarios.txt and 64 Rust sources: 68 files and 49,689 lines at 99d20220, with 157 scenarios and 169 other tests), scripts/nvx_tools/runtime_adapter_tests.py, nvx.py's test-runtime-adapter, and RuntimeAdapterSuiteTests. check_test_changes.py no longer names the adapter's scenarios.txt as test data, .gitignore no longer ignores its target/, and the change classifier's list of modules that no benchmark job runs drops the runner. The docs stop describing the adapter: test-runtime-adapter in doc/usage.md, tests/ in doc/project-structure.md, the adapter's lockfile in doc/distribution.md, and the nvx README's and the vectors README's mentions of its configurations, excerpts and capture interfaces.
• The case matrix keeps every fate. Its prose, and the README's index entry, say in the past tense what the deletion made past (that CI ran the adapter's scenarios, and that its README said what each proved). scripts/test-layout-allowlist.json held no entry of the adapter, so it doesn't change.
• Nothing that stays used the adapter. It was a crate with a workspace and a lockfile of its own, and nothing in nvx-rs or in the scripts imports it.

Every removed test, and its fate

check_test_changes.py reports 304 removed tests. Each has its row in the case matrix, with its fate:

Removed tests	Count	Fate in the case matrix
The adapter's scenarios, tests/runtime-adapter/tests/: template_capture 3, template_operations 4, clone_start 11, host_session 26, staged_images 4, layered_launch 16, vm_restart 3, vm_steps 3, vm_template 8, vm_clone 36	114	The adapter's scenarios, one row each, under its target: 76 rewritten, 38 retired
vm_layered's 43 scenarios, which its scenarios! macro generates, so the report shows them as the removal of vm_layered.rs's module and helpers	(43)	vm_layered (43): 38 rewritten, 5 retired
The adapter's other tests: src/**/tests.rs 78, tests/guest_session.rs 66, tests/independent_build.rs 9, tests/initramfs.rs 4, tests/listener_client.rs 3, tests/runtime.rs 3, tests/sandbox_names.rs 1, tests/step_hook.rs 5	169	The adapter's other tests, by file: 9 rewritten, 160 retired
scripts/test_nvx_tools.py::RuntimeAdapterSuiteTests, all 16	16	CI, Python tests: retired, with the runner
scripts/test_nvx_tools.py::CiConfigurationTests: test_nvx_rs_checks_the_runtime_adapter_in_each_configuration, test_ci_change_classification_runs_microvm_tests_for_the_runtime_adapter, test_runtime_adapter_scenarios_take_a_guest_agent_that_linux_builds	3	CI, Python tests: retired, with the adapter's CI wiring
CI wiring in ci.yml: the job nvx-microvm-adapter-whp, and run-nvx-microvm-tests.yml, which ci.yml now names 9 times instead of 10	2	CI: nvx-microvm-adapter-whp retired; the adapter's steps of run-nvx-microvm-tests.yml and its three configurations of check-nvx-rs retired or rewritten as their rows say

Together, the 114 and vm_layered's 43 are the matrix's 157 rows of the adapter's scenarios, of which 114 are rewritten and 43 retired. The matrix keeps none of the adapter's tests, so no test that it keeps leaves. Each name that the report gives a removed or modified test has its row, and no row names any of them as coverage (git grep of each name in the matrix); the rows of the seven modified tests already say what this PR removes from them.

What the deletion leaves without a user

Not deleted here (SL6.x deletes providers after their consumers); listed for those slices. Each has no user outside its own module once the adapter goes, as git grep over the non-test code of nvx-rs/src shows:

• SL6.11a (nvx-rs slimming 4.2.4: the exec engine, the process modules and the old layered init are gone #1123), the exec engine: nvx::exec (Runner, Peer, the frames, Limits, Timers, Unit), used only by guest::exec::binding, and guest::exec::binding::Binding, which nothing uses.
• SL6.2b (nvx-rs slimming 4.2.2: the old clone path, template store and sandbox store are gone #1121), the old clone path: host::template's CloneControl, ClonePlan, CloneRequest, the clone and failure records (CloneRecords, CloneFailure, FailureRecord), store-based reattach (reattach_clone, ReattachedClone) and RestoreDeadlines.
• SL6.2a (nvx-rs slimming 4.2.2: the old clone path, template store and sandbox store are gone #1121), the template store: host::template::Store (create_template among its methods), its leases (Acquired), its capture transactions (Created, Progress, Teardown, Retirement) and TemplatePlan.
• SL6.11c (nvx-rs slimming 4.2.1: the code that stays stops using what leaves #1120), the old capture steps: AdmissionFence, CapturePreparation (prepare), CaptureBarrier (cancel), Restored (into_parts) and CaptureError (into_cause). nvx::guest::clone, the compatibility alias of guest::activation that eb1c37e kept for the adapter, has no user either.
• Also, for SL6.3 (nvx-rs slimming 4.2.3: the old configs, the old launch code and bundled are gone #1122): the planning of an adapter's own guest, SandboxPlan::adapter, SandboxPlan::check_adapter_launch and PreparedLaunch::adapter_arguments, now used only inside host::sandbox and by the old clone path.

Follow-ups, not in this PR

• scripts/nvx_tools/kernel_features.py still names the adapter's tests ("the runtime adapter's clone tests", "GPT tests", "vm_layered test", and "the runtime adapter") among the validation of five kernel features, and stays unchanged here. One later PR updates every entry that names the adapter, after SL6.11b deletes guest::sys::entry's per-exec parts, which the diagnostics feature names as its consumer: that PR decides that feature's validator, today only the retired vm_layered::root_profiles_enter_the_root, and its setting, with one rebuild of the kernels, whose cache key the inventory is an input of.
• nvx-rs/src/host/template/clone/restore.rs's rustdoc gives the test adapter as the origin of two deadlines of the old clone path; SL6.2b deletes the file.
• scripts/local_gates.py, which exists on dev only, keeps its rules for the adapter's three check-nvx-rs steps and tests/runtime-adapter/ among its nvx-rs inputs; they go when feature/nvx-refactor merges into dev.

Size

Measured against feature/nvx-refactor 99d20220:

• Core lines: 9 changed, 0 new. Each of the 9 is a line that only loses the adapter's part: the five if: conditions of run-nvx-microvm-tests.yml that drop inputs.runtime-adapter, check-nvx-rs's description, the two lines of ci.py's path patterns that drop tests/runtime-adapter/ and runtime_adapter_tests, and check_test_changes.py's test-data pattern. The counted files lose 178 lines of code.
• Counted files: 8, where the estimate says 6, all of which only lose lines: the six that the Scope names (ci.yml, run-nvx-microvm-tests.yml, check-nvx-rs, validate-nvx, ci.py, nvx.py), plus copilot-setup-steps.yml, whose comment said that check-nvx-rs checks the adapter, and check_test_changes.py, whose pattern named scenarios.txt. The 69 files that it only deletes don't count.

Commits

1. ci: stop building, running and gating on the runtime adapter
2. tests: delete the runtime adapter and its runner

Not in this PR

Rewriting tests that stay (SL5.1a to SL5.1c); deleting the providers above (SL6.x); the follow-ups above; changing retained VM, snapshot, CLI or library behavior; any other CI cleanup; and the later docs pass (SL6.10f), beyond the references that the deletion leaves dangling.

Validation

The rebase onto 99d20220 (SL3.8a1, SL3.8a2, SL3.8b, SL3.10a, SL5.1b, SL5.1c and #1508) met one conflict, in doc/ci.md's paragraph on the debug-kernel jobs, where SL5.1c dropped snapshot-tiers from their scenarios: the resolution keeps SL5.1c's list of scenarios and, as before, drops WHP's adapter job and the adapter's scenarios from what the guest and sandbox jobs cover. Everything else merged without conflict, and SL5.1b's and SL5.1c's new public steps (sandbox-gpt-layer, vm-lifecycle, snapshot-core and snapshot-tiers in "Run public managed sandbox acceptance") and matrix rows stay as they are.

CI run 43146765096 on 65284401: passed: 34 jobs succeeded, and the 8 that a pull request skips were skipped (the debug kernel on KVM and on WHP, the development release, the recording and persistence of performance results, the nvx crate's packaging and publication, and the merge-group canceller). The guest and sandbox job of each backend, KVM, MSHV and WHP, ran "Run public managed sandbox acceptance", with SL5.1b's and SL5.1c's smoke tests (sandbox-gpt-layer, vm-lifecycle, snapshot-core and snapshot-tiers), and passed; Required status check verified every required job, and no adapter job or step ran.

Locally on Windows, on 65284401:

Check	Result
python -m ruff check scripts .github/specula, python -m ruff format --check scripts .github/specula	passed
python -m pyright --pythonplatform Linux, --pythonplatform Windows	0 errors each
python scripts/check_markdown_links.py, python scripts/check_test_layout.py, python scripts/nvx.py check-kernel-config	passed
validate-nvx's Windows step: python -m compileall -q scripts, python -m unittest of its 22 modules	1824 tests OK, 73 skipped
python scripts\test_adversarial.py, python .github\skills\nvx-host-connect\scripts\test_hosts.py, and the nvx.py --help checks	84 OK (11 skipped), 4 OK, all pass; nvx.py test-runtime-adapter --help now exits 2
The case matrix's reference check, and its summary table's counts (below)	passed

On the earlier head a2fadde7 (on f834bcb9), which the rebase changed only in doc/ci.md's conflict, locally on Windows:

Check	Result
The first commit alone: ruff, format, links, layout, pyright on both platforms, and python -m unittest test_nvx_tools.CiConfigurationTests test_nvx_tools.RuntimeAdapterSuiteTests test_test_changes.ClassifyTests	passed; 107 tests OK, 6 skipped
nvx-rs, Rust 1.95.0, NVX_BUNDLE=skip: cargo clippy --locked -p nvx --lib --no-default-features -- -D warnings, cargo build --locked, cargo clippy --locked --all-targets --all-features -- -D warnings, cargo fmt --all --check, RUSTDOCFLAGS="-D warnings" cargo doc --locked --no-deps --all-features	passed
cargo +1.89 check --locked --all-targets --all-features	passed
cargo test --locked --no-default-features --test openvmm_vectors -- --ignored, --test openvmm_cpu_profiles -- --ignored	3 passed, 1 passed
cargo test --locked --all-features --lib error::tests, which reads nvx-rs/README.md	5 passed

The case matrix's reference check. SL5.1a's check, a script outside the repository, verifies that each Rust test, microVM scenario, Python test class and path that a row names exists, and that the matrix has exactly one row for each of the adapter's scenarios and other tests. It read the adapter's inventory, scenarios.txt and the adapter's sources, from the checkout, which no longer has them. So the deletion forces one change on it, and only that one: the adapter's inventory, the Python tests that retire with it, and the runner that a retired row names as what leaves are read from the base revision, where they still exist. Everything else, every pointer to a test, scenario, class or path that covers a rewritten or kept test, is checked in this branch. It passes on 65284401: 157 scenarios and 169 other tests of the adapter, 54 microVM scenarios and 26 CI Python tests, each with its one fate. The microVM scenarios now include SL5.1b's two, and run-console-restore, which SL3.8b retired and deleted, so the check accepts a retired row whose scenario is gone. Every count of the summary table equals its section's rows: 157 (0 kept, 114 rewritten, 43 retired), 169 (0, 9, 160), 54 (51, 2, 1), 69 (43, 3, 23) and 36 (35, 1, 0). A pointer to a missing test, a renamed scenario, and a retired test placed in a kept row each make it fail.

Dry selection, on 65284401.

• local_gates.py, dev's copy, against this branch's own actions and workflows: with its three rules for the adapter's check-nvx-rs steps, it stops at "steps no longer present" for exactly those three; without them, every other scripted step of check-quality, check-nvx-rs, validate-nvx and ci.yml's CLI jobs is mapped, and it selects test-changes, markdown-links, test-layout, quality-code, openvmm-vectors, openvmm-cpu-profiles, the nvx-rs gates, nvx-cli and openvmm-ci on both systems.
• nvx.py classify-ci-changes on this change selects every suite for pull_request, merge_group and push; on the adapter's paths alone, it now selects none.
• nvx.py check-required-ci, fed the expected result of each job, passes for pull_request, merge_group and push; Required status check's needs equal ci.py's 31 jobs.
• ci.yml, run-nvx-microvm-tests.yml, copilot-setup-steps.yml and both actions parse, every caller of run-nvx-microvm-tests.yml passes only inputs that it declares, and no job condition is unbalanced.

No microVM scenario ran locally: no runtime path changes. CI ran them, with the Linux nvx-rs gates (public API, macOS, the guest binaries), the full nvx-rs test suites and the hypervisor jobs, as above.

Changes to existing tests

python3 scripts/check_test_changes.py --base origin/feature/nvx-refactor with dev's script, which the Test changes workflow runs, lists 1445 changes to existing tests on 65284401, none relocated or added, the same as before the rebase; this branch's own script lists 1444, all but scenarios.txt, which it no longer names as test data.

• Removed: the adapter and its runner. The 304 removed tests above, with their 913 helpers, 23 modules, and 35 blocks each of inner attributes and imports; the runner's 18 helpers and imports, which the report counts as end-to-end tests; and tests/runtime-adapter/scenarios.txt, as test data. RuntimeAdapterSuiteTests goes with its helpers _scenarios and _run.
• Test policy: scripts/check_test_changes.py. Its test-data pattern drops tests/runtime-adapter/scenarios.txt.
• Modified tests, each of which only loses its adapter part, as the matrix's CI rows say ("SL5.2 removes the adapter's parts of what they check", "SL5.2 removes its adapter path"):
  • CiConfigurationTests.test_ci_jobs_download_exactly_the_guest_artifacts_that_they_read: its map of the nvx.py commands to the guest files that they read drops test-runtime-adapter.
  • CiConfigurationTests.test_ci_change_classification_selects_suites_by_input: drops the adapter's README from the documentation case, and the case of an adapter source as an input of the microVM tests alone.
  • CiConfigurationTests.test_ci_change_classification_covers_each_suite_input: drops its check that the microVM workflow builds in tests/runtime-adapter, and the adapter among the microVM tests' inputs.
  • CiConfigurationTests.test_ci_shares_openvmm_inputs_and_binary_artifacts: drops the adapter's job among the consumers of the OpenVMM artifacts; the microVM workflow downloads 10 artifacts, not 12 (the distro layer for the adapter alone, and the adapter's guest agent).
  • CiConfigurationTests.test_ci_runs_the_steps_after_the_default_microvm_suite_beside_it and CiConfigurationTests.test_every_microvm_job_uploads_its_scenario_durations: back to their form from before 73b168a, which split WHP's adapter job off, less the adapter's scenario step among the guest and sandbox steps: one selector, two jobs per backend, and every job uploads its failure logs and duration reports, with failure() and always().
  • ClassifyTests.test_paths_and_their_categories: drops the adapter's crate and its two paths, scenarios.txt and tests/runtime.rs. test_test_layout.py still checks crate_of across nested crates.
  • The imports of scripts/test_nvx_tools.py drop runtime_adapter_tests.
• CI test wiring. 87 removed lines: the adapter's steps and selector in run-nvx-microvm-tests.yml, its three configurations in check-nvx-rs, validate-nvx's two help checks, and ci.yml's job, selectors, needs and environment. 14 modified lines: check-nvx-rs's description, and the conditions that drop inputs.runtime-adapter, which the report pairs with the removed lines of the distro layer's download for the adapter alone. 5 lines "that may skip": the same five if: conditions, which lose a term that skipped steps, so they skip less, not more: the download of the distro layer for the whole default run, the two default-suite steps, and the two uploads. 2 removed tests: the job nvx-microvm-adapter-whp, and ci.yml's ninth instead of tenth use of run-nvx-microvm-tests.yml.

[github-actions]

This pull request changes existing tests

It modifies or removes 1445 existing test asset(s), listed below. Review each with care: a change to a test can hide a regression that the test caught. See doc/contribute.md#changes-to-existing-tests.

Test code

Change	What	Before	After
modified imports	the imports of scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:1	scripts/test_nvx_tools.py:1
modified test	def CiConfigurationTests.test_ci_jobs_download_exactly_the_guest_artifacts_that_they_read in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:5941	scripts/test_nvx_tools.py:5940
modified test	def CiConfigurationTests.test_ci_change_classification_selects_suites_by_input in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:7500	scripts/test_nvx_tools.py:7440
modified test	def CiConfigurationTests.test_ci_change_classification_covers_each_suite_input in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:7965	scripts/test_nvx_tools.py:7741
modified test	def CiConfigurationTests.test_ci_shares_openvmm_inputs_and_binary_artifacts in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:8989	scripts/test_nvx_tools.py:8760
modified test	def CiConfigurationTests.test_ci_runs_the_steps_after_the_default_microvm_suite_beside_it in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:10013	scripts/test_nvx_tools.py:9778
modified test	def CiConfigurationTests.test_every_microvm_job_uploads_its_scenario_durations in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:12837	scripts/test_nvx_tools.py:12519
modified test	def ClassifyTests.test_paths_and_their_categories in scripts/test_test_changes.py	scripts/test_test_changes.py:1107	scripts/test_test_changes.py:1107
removed attributes	the inner attributes of exec::tests	tests/runtime-adapter/src/exec/tests.rs:1
removed attributes	the inner attributes of frame::tests	tests/runtime-adapter/src/frame/tests.rs:1
removed attributes	the inner attributes of generations::tests	tests/runtime-adapter/src/generations/tests.rs:1
removed attributes	the inner attributes of probe::tests	tests/runtime-adapter/src/probe/tests.rs:1
removed attributes	the inner attributes of root::tests	tests/runtime-adapter/src/root/tests.rs:1
removed attributes	the inner attributes of template::tests	tests/runtime-adapter/src/template/tests.rs:1
removed attributes	the inner attributes of worker::activation::tests	tests/runtime-adapter/src/worker/activation/tests.rs:1
removed attributes	the inner attributes of worker::capture::tests	tests/runtime-adapter/src/worker/capture/tests.rs:1
removed attributes	the inner attributes of worker::entries::tests	tests/runtime-adapter/src/worker/entries/tests.rs:1
removed attributes	the inner attributes of worker::executions::tests	tests/runtime-adapter/src/worker/executions/tests.rs:1
removed attributes	the inner attributes of worker::mapping::tests	tests/runtime-adapter/src/worker/mapping/tests.rs:1
removed attributes	the inner attributes of worker::probes::tests	tests/runtime-adapter/src/worker/probes/tests.rs:1
removed attributes	the inner attributes of worker::tests	tests/runtime-adapter/src/worker/tests.rs:1
removed attributes	the inner attributes of clone_start (tests)	tests/runtime-adapter/tests/clone_start.rs:1
removed attributes	the inner attributes of common/gpt (tests)	tests/runtime-adapter/tests/common/gpt.rs:1
removed attributes	the inner attributes of common/mod (tests)	tests/runtime-adapter/tests/common/mod.rs:1
removed attributes	the inner attributes of guest_session (tests)	tests/runtime-adapter/tests/guest_session.rs:1
removed attributes	the inner attributes of guest_session/clones (tests)	tests/runtime-adapter/tests/guest_session.rs:4130
removed attributes	the inner attributes of host_session (tests)	tests/runtime-adapter/tests/host_session.rs:1
removed attributes	the inner attributes of independent_build (tests)	tests/runtime-adapter/tests/independent_build.rs:1
removed attributes	the inner attributes of initramfs (tests)	tests/runtime-adapter/tests/initramfs.rs:1
removed attributes	the inner attributes of layered_launch (tests)	tests/runtime-adapter/tests/layered_launch.rs:1
removed attributes	the inner attributes of listener_client (tests)	tests/runtime-adapter/tests/listener_client.rs:1
removed attributes	the inner attributes of runtime (tests)	tests/runtime-adapter/tests/runtime.rs:1
removed attributes	the inner attributes of sandbox_names (tests)	tests/runtime-adapter/tests/sandbox_names.rs:1
removed attributes	the inner attributes of staged_images (tests)	tests/runtime-adapter/tests/staged_images.rs:1
removed attributes	the inner attributes of step_hook (tests)	tests/runtime-adapter/tests/step_hook.rs:1
removed attributes	the inner attributes of template_capture (tests)	tests/runtime-adapter/tests/template_capture.rs:1
removed attributes	the inner attributes of template_operations (tests)	tests/runtime-adapter/tests/template_operations.rs:1
removed attributes	the inner attributes of vm_clone (tests)	tests/runtime-adapter/tests/vm_clone.rs:1
removed attributes	the inner attributes of vm_clone/restore_exclusion (tests)	tests/runtime-adapter/tests/vm_clone.rs:5375
removed attributes	the inner attributes of vm_layered (tests)	tests/runtime-adapter/tests/vm_layered.rs:1
removed attributes	the inner attributes of vm_restart (tests)	tests/runtime-adapter/tests/vm_restart.rs:1
removed attributes	the inner attributes of vm_steps (tests)	tests/runtime-adapter/tests/vm_steps.rs:1
removed attributes	the inner attributes of vm_template (tests)	tests/runtime-adapter/tests/vm_template.rs:1
removed helper	class RuntimeAdapterSuiteTests in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:20913
removed helper	def RuntimeAdapterSuiteTests._scenarios in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:20914
removed helper	def RuntimeAdapterSuiteTests._run in scripts/test_nvx_tools.py	scripts/test_nvx_tools.py:20922
removed helper	const KEY in exec::tests	tests/runtime-adapter/src/exec/tests.rs:20
removed helper	fn shared in exec::tests	tests/runtime-adapter/src/exec/tests.rs:24
removed helper	fn timers in exec::tests	tests/runtime-adapter/src/exec/tests.rs:31
removed helper	fn numeric in exec::tests	tests/runtime-adapter/src/exec/tests.rs:36

... and 1266 more, which the job's summary lists.

Test data

Change	What	Before	After
removed file	tests/runtime-adapter/scenarios.txt	tests/runtime-adapter/scenarios.txt

End-to-end tests

Change	What	Before	After
removed helper	assignment ADAPTER_DIRECTORY in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:30
removed helper	assignment PACKAGE in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:31
removed helper	assignment SCENARIOS in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:32
removed helper	assignment GUEST_AGENT in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:33
removed helper	assignment _TEST_LINE in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:41
removed helper	assignment _RESULT_LINE in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:42
removed helper	class Target in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:46
removed helper	def configure_parser in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:53
removed helper	def read_scenarios in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:80
removed helper	def cargo_test_targets in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:112
removed helper	def cargo_test in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:130
removed helper	def listed_tests in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:147
removed helper	def naming_problems in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:157
removed helper	def run_problems in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:175
removed helper	def listing in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:199
removed helper	def streamed in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:216
removed helper	def suite_problems in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:240
removed helper	def command_test_runtime_adapter in scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:276
removed imports	the imports of scripts/nvx_tools/runtime_adapter_tests.py	scripts/nvx_tools/runtime_adapter_tests.py:1

Test policy

Change	What	Before	After
modified file	scripts/check_test_changes.py	scripts/check_test_changes.py	scripts/check_test_changes.py

CI test wiring

Change	What	Before	After
added a line that may skip line	if: ${{ !inputs.guests-and-sandboxes && !inputs.debug-kernel && !inputs.shard }}		.github/workflows/run-nvx-microvm-tests.yml:137
added a line that may skip line	if: runner.os != 'Windows' && !inputs.guests-and-sandboxes		.github/workflows/run-nvx-microvm-tests.yml:192
added a line that may skip line	if: runner.os == 'Windows' && !inputs.guests-and-sandboxes		.github/workflows/run-nvx-microvm-tests.yml:202
added a line that may skip line	if: failure()		.github/workflows/run-nvx-microvm-tests.yml:1250
added a line that may skip line	if: always()		.github/workflows/run-nvx-microvm-tests.yml:1268
modified line	description: >-	.github/actions/check-nvx-rs/action.yml:2	.github/actions/check-nvx-rs/action.yml:2
modified line	Format, lint, document, and test the nvx crate, and the runtime adapter that builds on it	.github/actions/check-nvx-rs/action.yml:3	.github/actions/check-nvx-rs/action.yml:2
modified line	as an independent adapter	.github/actions/check-nvx-rs/action.yml:4	.github/actions/check-nvx-rs/action.yml:2
modified line	if: ${{ !inputs.guests-and-sandboxes && !inputs.runtime-adapter && !inputs.debug-kernel && !inputs.shard }}	.github/workflows/run-nvx-microvm-tests.yml:146	.github/workflows/run-nvx-microvm-tests.yml:137
modified line	uses: actions/download-artifact@​v8	.github/workflows/run-nvx-microvm-tests.yml:147	.github/workflows/run-nvx-microvm-tests.yml:137
modified line	with:	.github/workflows/run-nvx-microvm-tests.yml:148	.github/workflows/run-nvx-microvm-tests.yml:137
modified line	name: guest-ubuntu-distro	.github/workflows/run-nvx-microvm-tests.yml:149	.github/workflows/run-nvx-microvm-tests.yml:137
modified line	path: build	.github/workflows/run-nvx-microvm-tests.yml:150	.github/workflows/run-nvx-microvm-tests.yml:137
modified line	- name: Download Ubuntu distro layer for the runtime adapter alone	.github/workflows/run-nvx-microvm-tests.yml:155	.github/workflows/run-nvx-microvm-tests.yml:137
modified line	if: ${{ inputs.runtime-adapter && !inputs.guests-and-sandboxes && !inputs.debug-kernel }}	.github/workflows/run-nvx-microvm-tests.yml:156	.github/workflows/run-nvx-microvm-tests.yml:137
modified line	if: runner.os != 'Windows' && !inputs.guests-and-sandboxes && !inputs.runtime-adapter	.github/workflows/run-nvx-microvm-tests.yml:211	.github/workflows/run-nvx-microvm-tests.yml:192
modified line	if: runner.os == 'Windows' && !inputs.guests-and-sandboxes && !inputs.runtime-adapter	.github/workflows/run-nvx-microvm-tests.yml:221	.github/workflows/run-nvx-microvm-tests.yml:202
modified line	if: failure() && (inputs.guests-and-sandboxes || !inputs.runtime-adapter)	.github/workflows/run-nvx-microvm-tests.yml:1320	.github/workflows/run-nvx-microvm-tests.yml:1250
modified line	if: always() && (inputs.guests-and-sandboxes || !inputs.runtime-adapter)	.github/workflows/run-nvx-microvm-tests.yml:1338	.github/workflows/run-nvx-microvm-tests.yml:1268
removed line	- name: Check the runtime adapter's protocol-only configuration	.github/actions/check-nvx-rs/action.yml:173
removed line	shell: bash	.github/actions/check-nvx-rs/action.yml:174
removed line	working-directory: tests/runtime-adapter	.github/actions/check-nvx-rs/action.yml:175
removed line	run: |	.github/actions/check-nvx-rs/action.yml:176
removed line	set -euo pipefail	.github/actions/check-nvx-rs/action.yml:177
removed line	cargo "+${{ steps.toolchains.outputs.toolchain }}" fmt --all --check	.github/actions/check-nvx-rs/action.yml:178
removed line	cargo "+${{ steps.toolchains.outputs.toolchain }}" clippy --locked --all-targets \	.github/actions/check-nvx-rs/action.yml:179
removed line	-- -D warnings	.github/actions/check-nvx-rs/action.yml:180
removed line	cargo "+${{ steps.toolchains.outputs.toolchain }}" build --locked	.github/actions/check-nvx-rs/action.yml:181
removed line	cargo "+${{ steps.toolchains.outputs.toolchain }}" test --locked	.github/actions/check-nvx-rs/action.yml:182
removed line	RUSTDOCFLAGS="-D warnings" cargo "+${{ steps.toolchains.outputs.toolchain }}" doc \	.github/actions/check-nvx-rs/action.yml:183
removed line	--locked --no-deps	.github/actions/check-nvx-rs/action.yml:184
removed line	cargo "+${{ steps.toolchains.outputs.msrv }}" check --locked --all-targets	.github/actions/check-nvx-rs/action.yml:185
removed line	- name: Check the runtime adapter's host-only configuration	.github/actions/check-nvx-rs/action.yml:187
removed line	shell: bash	.github/actions/check-nvx-rs/action.yml:188
removed line	working-directory: tests/runtime-adapter	.github/actions/check-nvx-rs/action.yml:189
removed line	run: |	.github/actions/check-nvx-rs/action.yml:190
removed line	set -euo pipefail	.github/actions/check-nvx-rs/action.yml:191
removed line	cargo "+${{ steps.toolchains.outputs.toolchain }}" clippy --locked --all-targets \	.github/actions/check-nvx-rs/action.yml:192
removed line	--features host -- -D warnings	.github/actions/check-nvx-rs/action.yml:193
removed line	cargo "+${{ steps.toolchains.outputs.toolchain }}" build --locked --features host	.github/actions/check-nvx-rs/action.yml:194
removed line	cargo "+${{ steps.toolchains.outputs.toolchain }}" test --locked --features host	.github/actions/check-nvx-rs/action.yml:195
removed line	RUSTDOCFLAGS="-D warnings" cargo "+${{ steps.toolchains.outputs.toolchain }}" doc \	.github/actions/check-nvx-rs/action.yml:196
removed line	--locked --no-deps --features host	.github/actions/check-nvx-rs/action.yml:197
removed line	cargo "+${{ steps.toolchains.outputs.msrv }}" check --locked --all-targets --features host	.github/actions/check-nvx-rs/action.yml:198
removed line	- name: Check the runtime adapter's guest-only configuration	.github/actions/check-nvx-rs/action.yml:201
removed line	if: runner.os == 'Linux'	.github/actions/check-nvx-rs/action.yml:202
removed line	shell: bash	.github/actions/check-nvx-rs/action.yml:203
removed line	working-directory: tests/runtime-adapter	.github/actions/check-nvx-rs/action.yml:204
removed line	run: |	.github/actions/check-nvx-rs/action.yml:205
removed line	set -euo pipefail	.github/actions/check-nvx-rs/action.yml:206

... and 58 more, which the job's summary lists.

Relocated unchanged: 0; added: 0. Compared the merge base 99d2022085fb with 65284401e189.

[Copilot]

🔵 Needs a closer look

The adapter deletion depends on SL5.1b/SL5.1c replacements absent from this snapshot, so prerequisite rebases and successful KVM/MSHV/WHP cold-boot and snapshot acceptance still need confirmation.

No open issues 🎉

What changed in this PR

Removes NVX’s obsolete runtime adapter and its dedicated tooling as SL5.2 of the library-slimming workstream (#1119). This deletion depends on the replacement real-VM acceptance work in #1118; retained runtime behavior is outside its scope.

Changes:

• Deletes the adapter crate, its tests and scenario inventory, and its CLI runner.
• Removes adapter-specific CI builds, jobs, selectors and required-status dependencies.
• Cleans up documentation and tooling references while preserving test dispositions in the acceptance matrix.

File	Description
tests/​runtime-adapter/​tests/​vm_steps.rs	Deletes VM launch-step scenarios.
tests/​runtime-adapter/​tests/​vm_restart.rs	Deletes restart and runtime-identity scenarios.
tests/​runtime-adapter/​tests/​step_hook.rs	Deletes step-hook tests.
tests/​runtime-adapter/​tests/​sandbox_names.rs	Deletes sandbox-name regression test.
tests/​runtime-adapter/​tests/​runtime.rs	Deletes artifact identity tests.
tests/​runtime-adapter/​tests/​listener_client.rs	Deletes listener-client regressions.
tests/​runtime-adapter/​tests/​initramfs.rs	Deletes adapter initramfs tests.
tests/​runtime-adapter/​src/​worker/​tests.rs	Deletes worker child-management tests.
tests/​runtime-adapter/​src/​worker/​probes/​tests.rs	Deletes worker probe tests.
tests/​runtime-adapter/​src/​worker/​order.rs	Deletes mapping and startup sequencing.
tests/​runtime-adapter/​src/​worker/​mapping/​tests.rs	Deletes mapping probe tests.
tests/​runtime-adapter/​src/​worker/​executions/​tests.rs	Deletes execution cancellation regression.
tests/​runtime-adapter/​src/​worker/​entries/​tests.rs	Deletes entry probe tests.
tests/​runtime-adapter/​src/​worker/​capture/​tests.rs	Deletes capture and handshake tests.
tests/​runtime-adapter/​src/​runtime.rs	Deletes adapter runtime discovery.
tests/​runtime-adapter/​src/​probe/​tests.rs	Deletes probe encoding tests.
tests/​runtime-adapter/​src/​probe.rs	Deletes probe and fact codecs.
tests/​runtime-adapter/​src/​lib.rs	Deletes adapter module exports and constants.
tests/​runtime-adapter/​src/​initramfs.rs	Deletes guest-agent initramfs assembly.
tests/​runtime-adapter/​src/​host/​order_error.rs	Deletes host sequencing errors.
tests/​runtime-adapter/​src/​host/​map_reply.rs	Deletes mapping reply type.
tests/​runtime-adapter/​src/​hook.rs	Deletes launch pause and exit hooks.
tests/​runtime-adapter/​src/​generations/​tests.rs	Deletes generation eviction tests.
tests/​runtime-adapter/​src/​generations.rs	Deletes adapter generation management.
tests/​runtime-adapter/​scenarios.txt	Deletes adapter scenario inventory.
tests/​runtime-adapter/​Cargo.toml	Deletes adapter crate manifest.
scripts/​test_test_changes.py	Removes adapter classification examples.
scripts/​nvx.py	Removes test-runtime-adapter registration and import.
scripts/​nvx_tools/​ci.py	Removes adapter gates and path classification.
scripts/​check_test_changes.py	Removes adapter scenario-data pattern.
README.md	Describes the adapter deletion in past tense.
nvx-rs/​tests/​vectors/​README.md	Removes adapter vector-consumer documentation.
nvx-rs/​README.md	Removes obsolete adapter references and links.
doc/​usage.md	Removes adapter command documentation.
doc/​project-structure.md	Removes adapter directory and build-output entries.
doc/​distribution.md	Removes adapter lockfile guidance.
doc/​contribute.md	Removes adapter validation and test-placement guidance.
doc/​acceptance-case-matrix.md	Updates historical wording while retaining dispositions.
.gitignore	Removes adapter build-output exclusion.
.github/​workflows/​run-nvx-microvm-tests.yml	Removes adapter selector and steps; simplifies conditions.
.github/​workflows/​copilot-setup-steps.yml	Updates only the Rust-version check comment.
.github/​workflows/​ci.yml	Removes adapter artifacts, WHP job and dependencies.
.github/​skills/​nvx-openvmm-promote/​SKILL.md	Removes adapter-specific validation guidance.
.github/​copilot-instructions.md	Removes adapter validation instructions.
.github/​actions/​validate-nvx/​action.yml	Removes adapter command-help checks.
.github/​actions/​check-nvx-rs/​action.yml	Removes adapter configuration checks.

_{Review effort: Balanced}

[Pedro Henrique Penna (ppenna)]

No change needed here, on Copilot's review of a2fadde7: the dependency that it flags is by design. This pull request stays a Draft and merges only after SL5.1c (#1118), whose smoke tests are the snapshot coverage that the case matrix names, and after SL5.1b (#1496), whose cold cells and vm-lifecycle scenario are the cold-boot coverage. At its merge turn, it rebases onto feature/nvx-refactor with both, and it merges only once that head's CI passes, the KVM, MSHV and WHP microVM jobs that run those scenarios among it.

[Copilot]

🔵 Needs a closer look

Removing the real-VM acceptance suite requires maintainer confirmation that SL5.1b/SL5.1c prerequisites are integrated and replacement cold-boot and snapshot tests pass on post-rebase KVM, MSHV, and WHP CI.

No open issues 🎉

_{Review effort: Balanced}

[Pedro Henrique Penna (ppenna)]

No change needed here, on Copilot's review of 65284401: the prerequisites are integrated and their tests pass on this head. SL5.1b (#1496) and SL5.1c (#1500) are in feature/nvx-refactor at 99d20220, onto which this branch is rebased. CI run 43146765096 on 65284401 passed: the guest and sandbox jobs on KVM, MSHV and WHP ran "Run public managed sandbox acceptance" with sandbox-gpt-layer, vm-lifecycle, snapshot-core and snapshot-tiers, the cold-boot and snapshot smoke tests that the case matrix names, and Required status check passed.