[Enrique Saurez (esaurez)]

Part of #1103 and #1076. Supporting input-composition Draft only; this does not implement production SL2.16 and is not ready to merge.

What and why

Compose the actual published launch/settings and snapshot-capture APIs so a separate SL2.16 consumer can use one coherent source. The direct base is #1434's existing branch, esaurez/issue1099-sl28b-20261110-6789d491.

Input	Exact head	Exact tree
#1434, first parent	4fdf55db0384354980a1267f64b5701d500969b8	2db5b7cfaa040d45ff217596b554037d13ccd641
#1455, ordinary-merge input	1148a7487995e02f3a39c6cf384f5d6d825f40ce	f3991b84a2f23af306125a9467a9496c64b99519
This prepared source	0eaadb9c51d74e4de200710dc64df1f822bb9aa0	be3aa40ef1945b8acb65379d0341a33c3141cee8

Merge 929e4edc18a48ea8485fd377c910d05fc3e429d3 has exactly the two published inputs as its ordered parents. Its normal successor only applies the pinned formatter's import wrapping. OpenVMM stays at 14dc4116ec7e57567633c4b7b07892aca3a58522. No old private aggregate, obsolete input join or producer rewrite is used.

The four conflict paths are nvx-rs/README.md, host/config/mod.rs, host/vm.rs and host/vm/tests.rs. Reconciliation retains the existing resolved-NIC helper with the capture's deny-all rendering, the owned configuration/NIC and inherited-resource wrapper with the data-only capture context, and both getters and the complete ownership-transfer method. Only the return/destructuring tuple needs combined plumbing. The README says to clone the context before consuming Prepared.

The settings and command/spawn method bodies remain byte-identical to #1434. Capture-context and sparse-disk helpers remain byte-identical to #1455; create is its exact existing statement/field/tuple union with #1434. The fourteen other incoming changed blobs are exact #1455 blobs. All VM test/fixture function names form the exact producer union, with no rewritten bodies. Both checked public-API listings are the exact union, with no additional items.

This preserves strict Windows trusted-log-job refusal before child creation, complete resource/log/argument ownership, confirmed cleanup and retained error/exit identities. The strict snapshot reader, private artifacts, NIC/geometry/console compatibility, complete per-snapshot time contract and unchanged compatibility identity are inherited unchanged. Current resolved DNS/publication/proxy/NIC behavior is retained. The test-layout file is its automatic producer union: the capture removes three obsolete VM constant hooks while the incoming guest-init allowance is preserved; no architecture scanner or cycle waiver changes.

Size

Own conservative reconciliation: 5 added core lines (three wrapped import rows and two tuple-plumbing rows), 2 production resolution files, and 0 novel production behavior, control flow, APIs or test bodies. Comments, documentation and tests are excluded, using the repository Rust tokenizer.

For transparency, the complete diff from #1434 also contains the already-published producer work: 619 added / 193 removed core lines across 8 production paths, 21 tracked paths total. Those aggregate inherited counts are not reported as five newly authored lines, nor as 619 lines of new implementation in this task.

Test changes

The immediate-parent inventory reports 9 existing test-asset changes, 0 relocations and 45 additions, all inherited from the published sources. No test is retired or weakened by this composition:

• host::template::store::tests imports the shared artifact inventory from host::snapshot.
• cold_boot_arguments_refuse_capture_configurations is the producer's rewrite to capture_command_lines_require_one_init_sandbox_selector, reflecting the now-supported capture path while requiring the exact sandbox selector.
• keys_read_back_from_their_canonical_encoding hashes the specified compatibility prefix; keys_of_machines_that_no_manifest_describes_are_refused still corrupts the invariant field before the time suffix.
• cold_creation_is_inspectable_without_a_process_listener_or_capability_file retains its existing assertions and adds the producer's absent-capture-context assertion.
• The obsolete OPENVMM, CAPTURE_IMAGE and CAPTURE_SCRATCH dead-code hooks disappear because capture now uses those constants; the layout allowance tightens accordingly.
• snapshot-key-v1.txt includes the complete persisted time fields, retaining the producer's independent compatibility identities and malformed-vector oracles.

The separate origin/dev inventory is inherited workstream accounting, not an execution count or this task's own test scope.

Validation

These are actual checks of 0eaadb9c51d74e4de200710dc64df1f822bb9aa0 / be3aa40ef1945b8acb65379d0341a33c3141cee8, completed before publication: Linux at 2026-11-10T23:19:04Z, Windows at 2026-11-10T23:19:26Z. Both used real private Git source/native metadata, exact native source, Rust/Cargo 1.95.0, private mutable caches/targets and fresh physical/commit/disk admission. scripts/nvx.py verify passed before Cargo; Windows initialized MSVC in the same cmd.exe process as each Cargo command.

Passed on both hosts, with NVX_BUNDLE=skip:

cargo +1.95.0 check --locked --manifest-path nvx-rs/Cargo.toml --all-targets --all-features
cargo +1.95.0 check --locked --manifest-path nvx-rs/Cargo.toml --no-default-features --features host --example external-launch
cargo +1.95.0 check --locked --manifest-path tests/runtime-adapter/Cargo.toml --all-targets --features host

Crate/adapter formatting, warning-denied affected Clippy and the required minimal-library Clippy, test layout, Markdown links and both test inventories also passed. Linux generated and compared both platform API snapshots successfully. The selected Boot has only command_line and capture; the unchanged external example compiles against that actual shape without speculative fields.

Focused existing VM preparation/settings/command/capture tests: Linux 51 passed / 3 ignored; Windows 46 passed / 3 ignored. Focused configuration/capture-rendering tests: 42 passed / 0 ignored on each. Counts are per command; ignored helpers and the hardware cold-spawn case are not runtime passes.

The earlier 929e4edc attempt is retained as failed preparation: Linux cache copying stopped before Cargo on an unrelated cached native test symlink loop; Windows stopped at import formatting before compilation/tests. The registry-only private-cache correction and formatting successor above are the actual checked source. No failed attempt or historical producer result is relabeled as passing.

Known inherited failure and unrun work

The architecture gate still fails on both hosts, exit 101:

snapshot -> vm -> snapshot
snapshot -> vm: src/host/snapshot/capture.rs:18: crate::host::vm::OUTCOME
vm -> snapshot: crate::host::snapshot::CaptureContext

This is the selected #1455 producer's existing layering defect, not a pass, waiver or repair in this join. Its separate producer correction remains required. Compilation and focused passes do not establish full CI or conformance.

No whole feature/MSRV matrix, OpenVMM/kernel/guest build, VM boot, SL2.15 hardware gate, extra unchanged snapshot/time/privacy suite, manual native review or manual Copilot request was repeated solely for mechanical adoption. Historical producer reviews are not reviews of this head. No manual CI dispatch/rerun, Ready transition, merge, auto-merge or native-stack mutation is requested or performed.

Production SL2.16 remains separate: create(Some(snapshot)) still refuses the input. This PR adds no restore view/hard links, restore arguments or policy, ready-listener handoff through Launched/VmmCommand, restore example, lock/store/ledger/fallback or new framework. This ordinary dependent PR is not a native stack registration.

[github-actions]

This pull request changes existing tests

It modifies or removes 11 existing test asset(s), listed below. Review each with care: a change to a test can hide a regression that the test caught. See doc/contribute.md#changes-to-existing-tests.

Test code

Change	What	Before	After
modified imports	the imports of host::template::store::tests	nvx-rs/src/host/template/store/tests.rs:5	nvx-rs/src/host/template/store/tests.rs:5
modified test	fn cold_boot_arguments_refuse_capture_configurations in host::config::tests (renamed to capture_command_lines_require_one_init_sandbox_selector)	nvx-rs/src/host/config/tests.rs:1123	nvx-rs/src/host/config/tests.rs:1208
modified test	fn a_vmm_whose_log_is_no_file_of_a_disk_volume_starts_without_a_job in host::platform::windows::tests	nvx-rs/src/host/platform/windows/tests.rs:1014	nvx-rs/src/host/platform/windows/tests.rs:1091
modified test	fn keys_read_back_from_their_canonical_encoding in host::snapshot::key::tests	nvx-rs/src/host/snapshot/key/tests.rs:661	nvx-rs/src/host/snapshot/key/tests.rs:720
modified test	fn keys_of_machines_that_no_manifest_describes_are_refused in host::snapshot::key::tests	nvx-rs/src/host/snapshot/key/tests.rs:800	nvx-rs/src/host/snapshot/key/tests.rs:859
modified test	fn cold_creation_is_inspectable_without_a_process_listener_or_capability_file in host::vm::tests	nvx-rs/src/host/vm/tests.rs:741	nvx-rs/src/host/vm/tests.rs:1160
modified test	fn the_log_and_inherited_resources_stay_open_without_reopening_their_paths in host::vm::tests	nvx-rs/src/host/vm/tests.rs:990	nvx-rs/src/host/vm/tests.rs:1410
removed hook	the test hooks of const OPENVMM in host::vm	nvx-rs/src/host/vm.rs:63
removed hook	the test hooks of const CAPTURE_IMAGE in host::vm	nvx-rs/src/host/vm.rs:81
removed hook	the test hooks of const CAPTURE_SCRATCH in host::vm	nvx-rs/src/host/vm.rs:87

Test data

Change	What	Before	After
modified file	nvx-rs/tests/vectors/snapshot-key-v1.txt	nvx-rs/tests/vectors/snapshot-key-v1.txt	nvx-rs/tests/vectors/snapshot-key-v1.txt

Relocated unchanged: 0; added: 53. Compared the merge base eba4c8b6a6a1 with 0eaadb9c51d7.

[Pedro Henrique Penna (ppenna)]

Closing as superseded: everything that this pull request joined is in feature/nvx-refactor at 5947e4e8.

• Each of its own commits landed through host: hand owned cold-launch commands to callers #1434, host: prepare blockless capture launches #1454 or host: finish exited captures into snapshot entries #1455, either patch-identical or rebased with its conflicts resolved.
• Its one integration commit, 0eaadb9c51, only reformats an import list in nvx-rs/src/host/vm.rs. A later commit on the branch changed that list, and the branch's version is already formatted.

Reopen this pull request if anything is missing.