Skip to content

Update NVX runtime bundle to 0.2.0 - #1724

Open
Huzaifa Danish (huzaifa-d) wants to merge 1 commit into
mainfrom
user/modanish/nvx-runtime-bundle-0-2-0
Open

Huzaifa Danish (huzaifa-d) wants to merge 1 commit into
mainfrom
user/modanish/nvx-runtime-bundle-0-2-0

Conversation

@huzaifa-d

@huzaifa-d Huzaifa Danish (huzaifa-d) commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

Update aci_edge_sandboxes from 0.1.1 to 0.1.2.

🔍 Validation

Windows x64 with WHP; Cargo commands ran from src. The test runs used an isolated LOCALAPPDATA because the host's existing NVX state directory failed its ACL check.

✅ Checklist

  • Signed the Contributor License Agreement
  • Linked to an issue
  • For features or changes requiring a spec: linked the issue with maintainer-applied feature-accepted
  • For implementation: linked the required approved and merged design/API spec, or explained why no spec is required
  • Feature issue remains open unless this PR completes all agreed implementation, validation, and documentation
  • Updated documentation (if applicable)
  • Updated Copilot instructions (if build, architecture, or conventions changed)
  • If this PR changes Cargo.lock, the dependency-feed-check check passes (see pull request builds)

📋 Issue Type

  • Bug fix
  • Feature
  • Task

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 21:05
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The trusted binary and guest-image update requires maintainer confirmation of the internal checksum-manifest digest and Windows/dependency-feed validation, which this review could not independently verify.

No open issues 🎉

What changed in this PR

Updates MXC’s Windows NVX backend to use the signed 0.2.0 runtime bundle through aci_edge_sandboxes 0.1.2, aligning dependency pins, integrity verification, and documentation.

Changes:

  • Updates aci_edge_sandboxes, its model dependency, and the transitive nvx dependency.
  • Replaces the approved checksum-manifest hash and records the new archive digest.
  • Updates the NVX guide’s bundle version and signed-agent documentation link.
File Description
src/​mxc-sdk/​src/​backends/​nvx/​signature_verification.rs Updates the approved manifest hash and archive digest comment.
src/​mxc-sdk/​Cargo.toml Pins aci_edge_sandboxes to 0.1.2.
src/​Cargo.lock Records updated dependency versions and checksums.
docs/​backends/​nvx/​nvx.md Aligns bundle guidance and documentation links with the update.

Review effort: Balanced

@huzaifa-d
Huzaifa Danish (huzaifa-d) marked this pull request as ready for review November 10, 2026 21:22
@huzaifa-d
Huzaifa Danish (huzaifa-d) requested a review from a team as a code owner November 10, 2026 21:22

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants