Skip to content

Migrate Authorization to new tool design#2885

Open
alzimmermsft wants to merge 2 commits into
microsoft:mainfrom
alzimmermsft:MigrateAuthorizationToNewToolDesign
Open

Migrate Authorization to new tool design#2885
alzimmermsft wants to merge 2 commits into
microsoft:mainfrom
alzimmermsft:MigrateAuthorizationToNewToolDesign

Conversation

@alzimmermsft

@alzimmermsft alzimmermsft commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates Authorization tools to new design where Register and Bind options are based on Option attributes.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Azure Authorization tool’s role assignment list command to the newer command/option-binding design that uses [Option] attributes and the SubscriptionCommand<TOptions, TResult> base, aligning it with other modernized tools in the repo.

Changes:

  • Updated RoleAssignmentListCommand to use the new SubscriptionCommand<,> pattern and option attribute binding.
  • Reworked RoleAssignmentListOptions to an ISubscriptionOption POCO with [Option] attributes (including tenant/subscription/retry and required scope).
  • Updated unit test base class usage and removed obsolete option definition plumbing (including deleting OptionDefinitions.Authorization.Scope).

Invoking Livetests

Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.Authorization/tests/Azure.Mcp.Tools.Authorization.Tests/RoleAssignmentListCommandTests.cs Switches to the subscription-aware unit test base to support the new command constructor/dependencies.
tools/Azure.Mcp.Tools.Authorization/src/Options/RoleAssignmentListOptions.cs Moves to attribute-based option definitions and makes Scope required under the new binder.
tools/Azure.Mcp.Tools.Authorization/src/GlobalUsings.cs Removes a now-unneeded global System.CommandLine using for this tool project.
tools/Azure.Mcp.Tools.Authorization/src/Commands/RoleAssignmentListCommand.cs Migrates the command implementation to the new SubscriptionCommand<,> execution model and option binding.
servers/Azure.Mcp.Server/changelog-entries/1781542129343.yaml Adds a server changelog entry for the Authorization tool change.
core/Microsoft.Mcp.Core/src/Models/Option/OptionDefinitions.cs Removes the legacy Authorization --scope option definition that’s no longer referenced.

Comment thread servers/Azure.Mcp.Server/changelog-entries/1781542129343.yaml
@alzimmermsft alzimmermsft changed the title Migrate authorization to new tool design Migrate Authorization to new tool design Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants