Migrate Authorization to new tool design#2885
Open
alzimmermsft wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Azure Authorization tool’s role assignment list command to the newer command/option-binding design that uses [Option] attributes and the SubscriptionCommand<TOptions, TResult> base, aligning it with other modernized tools in the repo.
Changes:
- Updated
RoleAssignmentListCommandto use the newSubscriptionCommand<,>pattern and option attribute binding. - Reworked
RoleAssignmentListOptionsto anISubscriptionOptionPOCO with[Option]attributes (including tenant/subscription/retry and required scope). - Updated unit test base class usage and removed obsolete option definition plumbing (including deleting
OptionDefinitions.Authorization.Scope).
Invoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Authorization/tests/Azure.Mcp.Tools.Authorization.Tests/RoleAssignmentListCommandTests.cs | Switches to the subscription-aware unit test base to support the new command constructor/dependencies. |
| tools/Azure.Mcp.Tools.Authorization/src/Options/RoleAssignmentListOptions.cs | Moves to attribute-based option definitions and makes Scope required under the new binder. |
| tools/Azure.Mcp.Tools.Authorization/src/GlobalUsings.cs | Removes a now-unneeded global System.CommandLine using for this tool project. |
| tools/Azure.Mcp.Tools.Authorization/src/Commands/RoleAssignmentListCommand.cs | Migrates the command implementation to the new SubscriptionCommand<,> execution model and option binding. |
| servers/Azure.Mcp.Server/changelog-entries/1781542129343.yaml | Adds a server changelog entry for the Authorization tool change. |
| core/Microsoft.Mcp.Core/src/Models/Option/OptionDefinitions.cs | Removes the legacy Authorization --scope option definition that’s no longer referenced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates Authorization tools to new design where Register and Bind options are based on
Optionattributes.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline