Skip to content

Add Azure ManagedCleanroom toolset with first commands: collaborations list and collaboration create#2882

Open
ShreyaSangwa wants to merge 14 commits into
microsoft:mainfrom
ShreyaSangwa:cleanrooms
Open

Add Azure ManagedCleanroom toolset with first commands: collaborations list and collaboration create#2882
ShreyaSangwa wants to merge 14 commits into
microsoft:mainfrom
ShreyaSangwa:cleanrooms

Conversation

@ShreyaSangwa

Copy link
Copy Markdown

What does this PR do?

Introduces the initial Azure ManagedCleanroom implementation in Azure MCP with two commands.

Commands added:

  • managedcleanroom collaborations list
  • managedcleanroom collaboration create

Implemented in this PR:

  • Added initial ManagedCleanroom command registration for the two commands above.
  • Added command implementations and option wiring for:
    • collaborations list
    • collaboration create
  • Added/updated supporting setup so both commands are discoverable in Azure MCP.
  • Applied related review follow-ups and metadata/doc consistency updates required for this initial slice.

Validation performed:

  • Build succeeded for the ManagedCleanroom toolset.
  • Build succeeded for supporting metadata/exporter tooling used by this PR.
  • Targeted command checks for the first two commands (managedcleanroom collaborations list and managedcleanroom collaboration create) are validated in this PR scope.

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution @ShreyaSangwa! We will review the pull request and get back to you soon.

@microsoft-github-policy-service

Copy link
Copy Markdown

@ShreyaSangwa please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

1 similar comment
@microsoft-github-policy-service

Copy link
Copy Markdown

@ShreyaSangwa please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new Azure Managed Cleanroom tool area to the Azure MCP Server, including command implementations, test scaffolding, and documentation/metadata updates to expose the new commands through the server.

Changes:

  • Introduces Azure.Mcp.Tools.ManagedCleanroom tool project with multiple data-plane and ARM-plane commands plus shared option models and JSON source-gen context.
  • Adds a dedicated unit test project with command-level tests and live-test resource templates/scripts.
  • Updates server registration, tool-metadata consolidation, and documentation (command reference + E2E prompts + changelog entries).

Reviewed changes

Copilot reviewed 125 out of 125 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep Adds test deployment resources/outputs for Managed Cleanroom live tests.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources-post.ps1 Adds post-deploy script to persist test settings and warn when endpoint not provided.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/assets.json Adds assets tagging config for the new test project.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Usings.cs Adds global test using for xUnit.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Runs/RunsGetCommandTests.cs Adds unit tests for managedcleanroom runs get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesVoteCommandTests.cs Adds unit tests for managedcleanroom queries vote.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesRunsCommandTests.cs Adds unit tests for managedcleanroom queries runs.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesRunCommandTests.cs Adds unit tests for managedcleanroom queries run.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesPublishCommandTests.cs Adds unit tests for managedcleanroom queries publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesListCommandTests.cs Adds unit tests for managedcleanroom queries list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesGetCommandTests.cs Adds unit tests for managedcleanroom queries get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Oidc/OidcSetIssuerUrlCommandTests.cs Adds unit tests for managedcleanroom oidc set-issuer-url.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Oidc/OidcKeysCommandTests.cs Adds unit tests for managedcleanroom oidc keys.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Oidc/OidcIssuerInfoCommandTests.cs Adds unit tests for managedcleanroom oidc issuer-info.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Invitations/InvitationsListCommandTests.cs Adds unit tests for managedcleanroom invitations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Invitations/InvitationsAcceptCommandTests.cs Adds unit tests for managedcleanroom invitations accept.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Datasets/DatasetsPublishCommandTests.cs Adds unit tests for managedcleanroom datasets publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Datasets/DatasetsListCommandTests.cs Adds unit tests for managedcleanroom datasets list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Datasets/DatasetsGetCommandTests.cs Adds unit tests for managedcleanroom datasets get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Consent/ConsentPutCommandTests.cs Adds unit tests for managedcleanroom consent put.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaborations/CollaborationsListCommandTests.cs Adds unit tests for managedcleanroom collaborations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaborations/CollaborationsGetCommandTests.cs Adds unit tests for managedcleanroom collaborations get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationGetReadonlyKubeconfigCommandTests.cs Adds unit tests for ARM kubeconfig retrieval command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationGetCommandTests.cs Adds unit tests for ARM collaboration get command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationEnableWorkloadCommandTests.cs Adds unit tests for ARM workload enable command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationCreateCommandTests.cs Adds unit tests for ARM collaboration create command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationAddCollaboratorCommandTests.cs Adds unit tests for ARM add-collaborator command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Azure.Mcp.Tools.ManagedCleanroom.Tests.csproj Adds new test project + dependencies.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/AuditEvents/AuditEventsListCommandTests.cs Adds unit tests for managedcleanroom auditevents list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/AssemblyAttributes.cs Adds test assembly attributes for env cleanup/collection behavior.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Analytics/AnalyticsSkrPolicyCommandTests.cs Adds unit tests for analytics SKR policy command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Analytics/AnalyticsGetCommandTests.cs Adds unit tests for analytics get command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomSerializerContext.cs Adds JSON source-gen context for JsonElement.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/IManagedCleanroomService.cs Defines service interface for all Managed Cleanroom operations.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Runs/RunsGetOptions.cs Adds CLI options model for runs get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesVoteOptions.cs Adds CLI options model for queries vote.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesRunsOptions.cs Adds CLI options model for queries runs.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesRunOptions.cs Adds CLI options model for queries run.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesPublishOptions.cs Adds CLI options model for queries publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesListOptions.cs Adds CLI options model for queries list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesGetOptions.cs Adds CLI options model for queries get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Oidc/OidcSetIssuerUrlOptions.cs Adds CLI options model for OIDC issuer registration.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Oidc/OidcKeysOptions.cs Adds CLI options model for OIDC keys.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Oidc/OidcIssuerInfoOptions.cs Adds CLI options model for OIDC issuer info.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/ManagedCleanroomOptionDescriptions.cs Adds shared option description constants.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Invitations/InvitationsListOptions.cs Adds CLI options model for invitations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Invitations/InvitationsAcceptOptions.cs Adds CLI options model for invitations accept.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Datasets/DatasetsPublishOptions.cs Adds CLI options model for datasets publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Datasets/DatasetsListOptions.cs Adds CLI options model for datasets list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Datasets/DatasetsGetOptions.cs Adds CLI options model for datasets get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Consent/ConsentPutOptions.cs Adds CLI options model for consent put.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaborations/CollaborationsListOptions.cs Adds CLI options model for collaborations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaborations/CollaborationsGetOptions.cs Adds CLI options model for collaborations get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationGetReadonlyKubeconfigOptions.cs Adds CLI options for ARM kubeconfig command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationGetOptions.cs Adds CLI options for ARM get command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationEnableWorkloadOptions.cs Adds CLI options for ARM enable-workload command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationCreateOptions.cs Adds CLI options for ARM create command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationAddCollaboratorOptions.cs Adds CLI options for ARM add-collaborator command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/AuditEvents/AuditEventsListOptions.cs Adds CLI options for audit events list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Analytics/AnalyticsSkrPolicyOptions.cs Adds CLI options for SKR policy.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Analytics/AnalyticsGetOptions.cs Adds CLI options for analytics get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs Registers the new area + command groups for Managed Cleanroom.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Runs/RunsGetCommand.cs Implements managedcleanroom runs get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesVoteCommand.cs Implements managedcleanroom queries vote.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesRunsCommand.cs Implements managedcleanroom queries runs.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesRunCommand.cs Implements managedcleanroom queries run.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesPublishCommand.cs Implements managedcleanroom queries publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesListCommand.cs Implements managedcleanroom queries list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesGetCommand.cs Implements managedcleanroom queries get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Oidc/OidcSetIssuerUrlCommand.cs Implements managedcleanroom oidc set-issuer-url.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Oidc/OidcKeysCommand.cs Implements managedcleanroom oidc keys.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Oidc/OidcIssuerInfoCommand.cs Implements managedcleanroom oidc issuer-info.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/ManagedCleanroomJsonContext.cs Adds JSON source-gen context used by commands.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Invitations/InvitationsListCommand.cs Implements managedcleanroom invitations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Invitations/InvitationsAcceptCommand.cs Implements managedcleanroom invitations accept.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Datasets/DatasetsPublishCommand.cs Implements managedcleanroom datasets publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Datasets/DatasetsListCommand.cs Implements managedcleanroom datasets list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Datasets/DatasetsGetCommand.cs Implements managedcleanroom datasets get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Consent/ConsentPutCommand.cs Implements managedcleanroom consent put.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaborations/CollaborationsListCommand.cs Implements managedcleanroom collaborations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaborations/CollaborationsGetCommand.cs Implements managedcleanroom collaborations get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationGetReadonlyKubeconfigCommand.cs Implements managedcleanroom collaboration get-readonly-kubeconfig.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationGetCommand.cs Implements managedcleanroom collaboration get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationEnableWorkloadCommand.cs Implements managedcleanroom collaboration enable-workload.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationCreateCommand.cs Implements managedcleanroom collaboration create.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationAddCollaboratorCommand.cs Implements managedcleanroom collaboration add-collaborator.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/AuditEvents/AuditEventsListCommand.cs Implements managedcleanroom auditevents list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Analytics/AnalyticsSkrPolicyCommand.cs Implements managedcleanroom analytics skr-policy.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Analytics/AnalyticsGetCommand.cs Implements managedcleanroom analytics get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Azure.Mcp.Tools.ManagedCleanroom.csproj Adds the new tool project and dependencies.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/AssemblyInfo.cs Exposes internals to the test assembly.
servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json Adds consolidated tool groupings mapping to managedcleanroom commands.
servers/Azure.Mcp.Server/src/Program.cs Registers the new Managed Cleanroom area in the server.
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md Adds E2E prompt coverage entries for managedcleanroom tools.
servers/Azure.Mcp.Server/docs/azmcp-commands.md Adds CLI help/reference section for managedcleanroom commands.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-runs-get.yaml Adds changelog entry for runs get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-vote.yaml Adds changelog entry for queries vote command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-runs.yaml Adds changelog entry for queries runs command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-run.yaml Adds changelog entry for queries run command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-publish.yaml Adds changelog entry for queries publish command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-list.yaml Adds changelog entry for queries list command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-get.yaml Adds changelog entry for queries get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-oidc-set-issuer-url.yaml Adds changelog entry for OIDC set issuer URL command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-oidc-keys.yaml Adds changelog entry for OIDC keys command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-invitations-list.yaml Adds changelog entry for invitations list command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-invitations-accept.yaml Adds changelog entry for invitations accept command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-datasets-publish.yaml Adds changelog entry for datasets publish command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-datasets-list.yaml Adds changelog entry for datasets list command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-datasets-get.yaml Adds changelog entry for datasets get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-consent-put.yaml Adds changelog entry for consent put command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-collaboration-get.yaml Adds changelog entry for ARM collaboration get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-collaboration-get-readonly-kubeconfig.yaml Adds changelog entry for kubeconfig command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-auditevents-list.yaml Adds changelog entry for audit events list command.
servers/Azure.Mcp.Server/changelog-entries/1780647747781.yaml Adds a rolled-up changelog entry for Managed Cleanroom toolset.
servers/Azure.Mcp.Server/CHANGELOG.md Adds top-level changelog bullets for new collaboration ARM commands.
servers/Azure.Mcp.Server/Azure.Mcp.Server.slnx Adds Managed Cleanroom source + test projects to server solution.
nuget.config Adds a local package source intended for Managed Cleanroom dependencies.
eng/tools/ToolMetadataExporter/src/Program.cs Adjusts Managed Identity credential initialization.
Microsoft.Mcp.slnx Adds Managed Cleanroom projects to the root solution.
Directory.Packages.props Updates Azure.Core/System.ClientModel versions and adds CleanRoom ARM package version.
.vscode/cspell.json Adds “cleanroom” spelling exceptions.
.github/CODEOWNERS Adds code owners for the new Managed Cleanroom tool directory.
Comments suppressed due to low confidence (10)

tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs:1

  • Only CollaborationsListCommand and CollaborationCreateCommand are registered and added to command groups, but the PR adds many additional commands (analytics/oidc/datasets/queries/invitations/auditevents and multiple collaboration ARM commands). As-is, those commands won't be resolvable from DI and/or won't appear in the command tree at runtime. Register the missing command types in ConfigureServices and add them under the appropriate CommandGroup hierarchy in RegisterCommands (e.g., analytics, oidc, datasets, queries, invitations, auditevents, plus the remaining collaboration subcommands).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • managedcleanroom_collaboration_create is a create/provision operation, but this consolidated tool marks it as destructive: true and describes deletion/modification of existing resources. If the repository uses destructive to mean delete/irreversible mutation, this metadata is likely incorrect and can cause risk-based routing/policy decisions to behave incorrectly. Update the metadata to reflect the actual behavior (create/updates vs delete), aligning with the command’s own metadata.
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • managedcleanroom_collaboration_create is a create/provision operation, but this consolidated tool marks it as destructive: true and describes deletion/modification of existing resources. If the repository uses destructive to mean delete/irreversible mutation, this metadata is likely incorrect and can cause risk-based routing/policy decisions to behave incorrectly. Update the metadata to reflect the actual behavior (create/updates vs delete), aligning with the command’s own metadata.
    tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep:1
  • baseName defaults to resourceGroup().name but is constrained to @maxLength(24). Resource group names commonly exceed 24 chars, so deployments can fail when the default is used. Consider generating a compliant default (e.g., take(resourceGroup().name, 24) or a uniqueString(...)-based name) or removing/tightening constraints only where they’re actually required.
    tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/ManagedCleanroomOptionDescriptions.cs:1
  • DocumentId is a shared constant name but the description is specific to 'dataset document to publish'. This constant is used by multiple dataset commands (publish/get), and may be reused by non-publish contexts later; the wording will then be misleading. Consider making the description neutral (e.g., 'dataset document to retrieve/publish') or splitting into separate constants if you want context-specific help text.

Comment thread nuget.config Outdated
Comment thread servers/Azure.Mcp.Server/docs/azmcp-commands.md Outdated
Comment thread servers/Azure.Mcp.Server/changelog-entries/1780647747781.yaml Outdated
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 15, 2026 12:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 6 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 15, 2026 12:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md Outdated
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 16, 2026 05:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md
Comment on lines +68 to +72
│ ├── Options/
│ │ ├── ManagedCleanroomOptionDefinitions.cs
│ │ ├── Collaboration/
│ │ │ └── [Options classes - mixed status]
│ │ └── [Options for all command groups]
Comment on lines +35 to +41
var result = await _service.ListCollaborationsAsync(
options.Endpoint,
options.ActiveOnly,
options.AllowUntrustedCert,
options.TokenScope,
options.Tenant,
cancellationToken).ConfigureAwait(false);
Comment thread .github/CODEOWNERS Outdated
Comment thread servers/Azure.Mcp.Server/Azure.Mcp.Server.slnx Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/IManagedCleanroomService.cs Outdated
Comment thread Directory.Packages.props
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants