Docs: list Advisor apply resource values#2876
Open
luohui1 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution @luohui1! We will review the pull request and get back to you soon. |
luohui1
requested review from
KarishmaGhiya,
alzimmermsft,
Copilot,
g2vinay,
hallipr,
jongio,
joshfree and
tmeschter
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Azure MCP Server documentation to clarify the allowed values for the --resource argument when applying Azure Advisor recommendations.
Changes:
- Documented the full set of accepted
--resourcevalues forazmcp advisor recommendation apply. - Added
cspell:ignoredirectives to prevent spell-check noise for Azure resource type identifiers.
Comment on lines
+334
to
+355
| The `--resource` parameter for `azmcp advisor recommendation apply` accepts the following values: | ||
|
|
||
| - `aad_domainservices` | ||
| - `apimanagement_service` | ||
| - `cognitiveservices_accounts` | ||
| - `compute_virtualmachines` | ||
| - `compute_virtualmachinescalesets` | ||
| - `containerregistry_registries` | ||
| - `containerservice_managedclusters` | ||
| - `dbforpostgresql_flexibleservers` | ||
| - `documentdb_databaseaccounts` | ||
| - `keyvault_vaults` | ||
| - `kubernetes_connectedclusters` | ||
| - `kubernetesconfiguration_extensions` | ||
| - `netapp_volumes` | ||
| - `network_applicationgatewaywebapplicationfirewallpolicies` | ||
| - `network_expressrouteports` | ||
| - `network_frontdoorwebapplicationfirewallpolicies` | ||
| - `sql_managedinstances` | ||
| - `storage_storageaccounts` | ||
| - `web_serverfarms` | ||
| - `web_staticsites` |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the supported
--resourcevalues forazmcp advisor recommendation applyto the Azure MCP command reference.The list matches the Advisor recommendation rule resources embedded under
tools/Azure.Mcp.Tools.Advisor/src/Resources.GitHub issue number?
Fixes #2762
Validation
git diff --checktools/Azure.Mcp.Tools.Advisor/src/Resources/*.json(20 documented values, 20 resource files)git diff --name-only | .\eng\common\spelling\Invoke-Cspell.ps1(new Advisor resource terms are ignored; this file still has existing unrelated cspell warnings)Not run:
dotnet build servers\Azure.Mcp.Server\srcbecause the local machine only has .NET SDK 8.0.422 installed and this repository requires SDK 10.0.201.Pre-merge Checklist
servers/Azure.Mcp.Server/docs/azmcp-commands.md