Migrate App Lens tools to new tool design#2872
Open
alzimmermsft wants to merge 3 commits into
Open
Conversation
alzimmermsft
requested review from
KarishmaGhiya,
RickWinter,
chidozieononiwu,
conniey,
sandeep-sen and
srnagar
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the AppLens tool command(s) to the newer command/options design where CLI options are derived from [Option] attributes and bound via the shared OptionBinder, removing the legacy manual RegisterOptions/BindOptions flow.
Changes:
- Converted
ResourceDiagnoseCommandto the newBaseCommand<TOptions, TResult>-style execution signature and removed manual option registration/binding. - Replaced the
GlobalOptions-derived options model and deleted the legacyAppLensOptionDefinitionsoption definitions. - Removed AppLens tool
GlobalUsings.csand added explicitSystem.Text.Jsonusings where needed; added a breaking-change changelog entry.
Invoking Livetests
Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs | Adds explicit System.Text.Json import after removal of AppLens global usings. |
| tools/Azure.Mcp.Tools.AppLens/src/Options/Resource/ResourceDiagnoseOptions.cs | Introduces attribute-based option definitions and removes GlobalOptions inheritance. |
| tools/Azure.Mcp.Tools.AppLens/src/Options/AppLensOptionDefinitions.cs | Deletes legacy System.CommandLine option definitions. |
| tools/Azure.Mcp.Tools.AppLens/src/Models/AppLensModels.cs | Adds explicit System.Text.Json import after global usings removal. |
| tools/Azure.Mcp.Tools.AppLens/src/Models/AppLensJsonContext.cs | Adds explicit System.Text.Json import after global usings removal. |
| tools/Azure.Mcp.Tools.AppLens/src/GlobalUsings.cs | Removes AppLens-specific global usings (System.CommandLine, System.Text.Json). |
| tools/Azure.Mcp.Tools.AppLens/src/Commands/Resource/ResourceDiagnoseCommand.cs | Migrates to new command base/signature and removes manual option plumbing. |
| servers/Azure.Mcp.Server/changelog-entries/1781295131142.yaml | Adds a breaking-changes entry for the AppLens parameter surface change. |
Comment on lines
29
to
31
| public sealed class ResourceDiagnoseCommand(ILogger<ResourceDiagnoseCommand> logger, IAppLensService appLensService) | ||
| : GlobalCommand<ResourceDiagnoseOptions> | ||
| : BaseCommand<ResourceDiagnoseOptions, ResourceDiagnoseCommandResult> | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates App Lens tools to new design where Register and Bind options are based on
Optionattributes.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline