Skip to content

Preserve percent-encoded href octets#2200

Closed
mturac wants to merge 1 commit into
microsoft:mainfrom
mturac:izon/fix-markitdown-2171-preserve-percent-hrefs
Closed

Preserve percent-encoded href octets#2200
mturac wants to merge 1 commit into
microsoft:mainfrom
mturac:izon/fix-markitdown-2171-preserve-percent-hrefs

Conversation

@mturac

@mturac mturac commented Jul 7, 2026

Copy link
Copy Markdown

Summary

Validation

  • cd packages/markitdown && PYTHONPATH=src uv run --with pytest --with markdownify --with beautifulsoup4 --with requests --with magika --with charset-normalizer --with defusedxml python -m pytest tests/test_module_misc.py -q -k percent_encoded_href
  • git diff --check -- packages/markitdown/src/markitdown/converters/_markdownify.py packages/markitdown/tests/test_module_misc.py
  • python3 -m py_compile packages/markitdown/src/markitdown/converters/_markdownify.py packages/markitdown/tests/test_module_misc.py

Fixes #2171

@mturac mturac force-pushed the izon/fix-markitdown-2171-preserve-percent-hrefs branch from af76aea to 8961296 Compare July 8, 2026 10:56
@mturac

mturac commented Jul 9, 2026

Copy link
Copy Markdown
Author

Closing this to avoid splitting review on the same issue. #2173 is already open for #2171 and covers the same percent-encoded href path, so I will leave that as the active review path.

@mturac mturac closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve percent-encoded octets in hrefs to avoid UTF-8 replacement (EUC-JP / Shift-JIS)

1 participant