fix: prevent docx math converter crash on math run elements with no text child (#2188)#2195
Open
Ruanyuxi1337 wants to merge 1 commit into
Open
fix: prevent docx math converter crash on math run elements with no text child (#2188)#2195Ruanyuxi1337 wants to merge 1 commit into
Ruanyuxi1337 wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2188.
In
do_r()insideomml.py, iterating overelm.findtext(./{0}t.format(OMML_NS))can crash withTypeError: 'NoneType' object is not iterableif there is a math run element (<m:r>) with no text child (<m:t>). This PR fixes it by using a fallback default of an empty string (elm.findtext(...) or "").A regression test is included.