Open
Conversation
… daemon-reload running on the node
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix an issue where containers lose access to NVIDIA GPUs by unconditionally setting the privileged flag to true for all user job containers. Previously, privileged mode was only enabled when the Docker-in-Docker (dind) runtime plugin was active. The change removes the conditional logic and makes all job containers run in privileged mode.
Key Changes:
- Removed conditional privileged mode based on
dindModeflag - Set
privileged: trueunconditionally for all user job containers in Kubernetes pod specifications
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set priviledge as true for user jobs to avoid NVidia GPUs losing in containers.