Repository navigation
Separate fs resolution from opening; improve perm handling - #1768
Merged
Jay Bosamiya (Microsoft) (jaybosamiya-ms) merged 1 commit intoOct 31, 2026
Conversation
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/ulitebox-backend-resolution-improvements
branch
from
October 31, 2026 01:07
f1b0012 to
37d312e
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
marked this pull request as ready for review
October 31, 2026 01:23
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
removed this pull request from the merge queue due to a manual request
Oct 31, 2026
|
🤖 SemverChecks 🤖 Click for details |
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
deleted the
jayb/ulitebox-backend-resolution-improvements
branch
October 31, 2026 01:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the file system backends to support resolving unopened targets. This allows multiple operations to be decoupled from opening, mostly to do with authorization. At its core, the idea is very simple: files/dirs can be resolved, and only resolved files/dirs can be opened; an unopened but resolved file/dir has value in many operations.
Concretely, this means a whole collection of fixups of several seemingly-unrelated issues that each had "local" fixes but instead benefit from this more disciplined fix that fixes the underlying root cause. The fixups:
O_TRUNCissues, overlay unnecessary-copy up issues, etc.fooinfoo/../bartoostatno longer needs toopenthe targetThere are known follow ups marked in the code, but this will be part of future PRs, rather than making this big PR even larger.