Skip to content

Add vsock stream sockets to the broker - #1766

Closed
Sangho Lee (sangho2) wants to merge 1 commit into
sanghle/ulitebox/vsock_1_driverfrom
sanghle/ulitebox/vsock_2_broker
Closed

Sangho Lee (sangho2) wants to merge 1 commit into
sanghle/ulitebox/vsock_1_driverfrom
sanghle/ulitebox/vsock_2_broker

Conversation

@sangho2

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

ℹ️ Note: This semver check was run against the sanghle/ulitebox/vsock_1_driver branch, not main or ulitebox.

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_added.ron

Failed in:
  trait method litebox_broker_core::fs::backend::Backend::rename_at in file /home/runner/work/litebox/litebox/litebox_broker_core/src/fs/backend.rs:226

--- failure enum_unit_variant_changed_kind: An enum unit variant changed kind ---

Description:
A public enum's exhaustive unit variant has changed to a different kind of enum variant, breaking possible instantiations and patterns.
        ref: https://doc.rust-lang.org/reference/items/enumerations.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/enum_unit_variant_changed_kind.ron

Failed in:
  variant UnixSocketResponse::Connect in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:786

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/enum_variant_added.ron

Failed in:
  variant FileResponse:Rename in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:902
  variant FileRequest:Rename in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:857
  variant UnixSocketName:Vsock in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/unix_socket.rs:100
  variant UnixSocketResponse:CreateVsock in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:780
  variant UnixSocketResponse:TakeError in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:802
  variant UnixSocketResponse:CheckConnect in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:804
  variant UnixSocketResponse:CancelConnect in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:806
  variant UnixSocketAddress:Vsock in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/unix_socket.rs:189
  variant UnixSocketRequest:CreateVsock in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:473
  variant UnixSocketRequest:TakeError in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:495
  variant UnixSocketRequest:CheckConnect in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:497
  variant UnixSocketRequest:CancelConnect in /home/runner/work/litebox/litebox/litebox_broker_protocol/src/message.rs:499

--- failure copy_impl_added: type now implements Copy ---

Description:
A public type now implements Copy, causing non-move closures to capture it by reference instead of moving it.
        ref: https://github.com/rust-lang/rust/issues/100905
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/copy_impl_added.ron

Failed in:
  litebox_common_linux::FutexFlags in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:2342

--- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value ---

Description:
The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`.
        ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/enum_no_repr_variant_discriminant_changed.ron

Failed in:
  variant SyscallRequest::Ppoll 66 -> 67 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:2987
  variant SyscallRequest::Pselect 67 -> 68 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:2994
  variant SyscallRequest::ArchPrctl 68 -> 69 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3002
  variant SyscallRequest::Readlink 69 -> 70 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3005
  variant SyscallRequest::Readlinkat 70 -> 71 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3010
  variant SyscallRequest::Openat 71 -> 72 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3016
  variant SyscallRequest::Ftruncate 72 -> 73 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3022
  variant SyscallRequest::Mknodat 73 -> 74 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3026
  variant SyscallRequest::Unlinkat 74 -> 75 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3032
  variant SyscallRequest::Newfstatat 75 -> 77 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3044
  variant SyscallRequest::Eventfd2 76 -> 78 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3050
  variant SyscallRequest::Pipe2 77 -> 79 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3054
  variant SyscallRequest::Clone 78 -> 80 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3058
  variant SyscallRequest::Clone3 79 -> 81 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3061
  variant SyscallRequest::SetThreadArea 80 -> 82 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3066
  variant SyscallRequest::ClockGettime 81 -> 83 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3069
  variant SyscallRequest::ClockGetres 82 -> 84 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3073
  variant SyscallRequest::ClockNanosleep 83 -> 85 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3077
  variant SyscallRequest::Gettimeofday 84 -> 86 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3083
  variant SyscallRequest::Time 85 -> 87 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3087
  variant SyscallRequest::Getrlimit 86 -> 88 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3090
  variant SyscallRequest::Setrlimit 87 -> 89 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3094
  variant SyscallRequest::Prlimit 88 -> 90 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3098
  variant SyscallRequest::SetTidAddress 89 -> 91 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3109
  variant SyscallRequest::Gettid 90 -> 92 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3112
  variant SyscallRequest::SetRobustList 91 -> 93 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3113
  variant SyscallRequest::GetRobustList 92 -> 94 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3116
  variant SyscallRequest::GetRandom 93 -> 95 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3121
  variant SyscallRequest::Getpid 94 -> 96 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3126
  variant SyscallRequest::Getppid 95 -> 97 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3127
  variant SyscallRequest::Setpgid 96 -> 98 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3128
  variant SyscallRequest::Getpgid 97 -> 99 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3132
  variant SyscallRequest::Getpgrp 98 -> 100 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3135
  variant SyscallRequest::Setsid 99 -> 101 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3136
  variant SyscallRequest::Getsid 100 -> 102 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3137
  variant SyscallRequest::Getuid 101 -> 103 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3140
  variant SyscallRequest::Geteuid 102 -> 104 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3141
  variant SyscallRequest::Getgid 103 -> 105 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3142
  variant SyscallRequest::Getegid 104 -> 106 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3143
  variant SyscallRequest::Sysinfo 105 -> 107 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3144
  variant SyscallRequest::CapGet 106 -> 108 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3147
  variant SyscallRequest::GetDirent64 107 -> 109 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3151
  variant SyscallRequest::SchedGetAffinity 108 -> 110 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3156
  variant SyscallRequest::SchedGetParam 109 -> 111 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3161
  variant SyscallRequest::SchedGetScheduler 110 -> 112 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3165
  variant SyscallRequest::SchedYield 111 -> 113 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3168
  variant SyscallRequest::Futex 112 -> 114 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3169
  variant SyscallRequest::Execve 113 -> 115 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3172
  variant SyscallRequest::Umask 114 -> 116 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3177
  variant SyscallRequest::Prctl 115 -> 117 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3180
  variant SyscallRequest::Alarm 116 -> 118 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3183
  variant SyscallRequest::Pause 117 -> 119 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3186
  variant SyscallRequest::RestartSyscall 118 -> 120 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3187
  variant SyscallRequest::SetITimer 119 -> 121 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3188
  variant SyscallRequest::GetITimer 120 -> 122 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3193
  variant SyscallRequest::Statx 121 -> 123 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3197
  variant SyscallRequest::TimerfdCreate 122 -> 124 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3204
  variant SyscallRequest::TimerfdSettime 123 -> 125 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3208
  variant SyscallRequest::TimerfdGettime 124 -> 126 in /home/runner/work/litebox/litebox/litebox_common_linux/src/lib.rs:3214

--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_added.ron

Failed in:
  trait method litebox_platform::time::Instant::saturating_add in file /home/runner/work/litebox/litebox/litebox_platform/src/time.rs:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant